Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error for schema name validation #14517

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

rohityadav1993
Copy link
Contributor

refactor

Addresses: #14511 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (59551e4) to head (c01f5dd).
Report is 1378 commits behind head on master.

Files with missing lines Patch % Lines
...ller/api/resources/PinotSchemaRestletResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14517      +/-   ##
============================================
+ Coverage     61.75%   63.88%   +2.13%     
- Complexity      207     1570    +1363     
============================================
  Files          2436     2673     +237     
  Lines        133233   146784   +13551     
  Branches      20636    22509    +1873     
============================================
+ Hits          82274    93770   +11496     
- Misses        44911    46096    +1185     
- Partials       6048     6918     +870     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.83% <0.00%> (+2.12%) ⬆️
java-21 63.75% <0.00%> (+2.13%) ⬆️
skip-bytebuffers-false 63.85% <0.00%> (+2.10%) ⬆️
skip-bytebuffers-true 63.73% <0.00%> (+36.01%) ⬆️
temurin 63.88% <0.00%> (+2.13%) ⬆️
unittests 63.87% <0.00%> (+2.13%) ⬆️
unittests1 55.57% <ø> (+8.68%) ⬆️
unittests2 34.57% <0.00%> (+6.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tibrewalpratik17 tibrewalpratik17 marked this pull request as ready for review November 22, 2024 06:52
@tibrewalpratik17 tibrewalpratik17 merged commit 453121d into apache:master Nov 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants