-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2571] Add hierarchy icon to queue node #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my suggestion, thanks.
+1, Nice icon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 38.77% 38.77%
=======================================
Files 2 2
Lines 49 49
=======================================
Hits 19 19
Misses 27 27
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Hi @wilfred-s, @craigcondit, What else we need to do to include the image from MIT license? The MIT lincese says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." |
We need to add a couple of lines to the License file. Like we did in the k8shim LICENSE file:
Besides that the repo has the following comment: |
I have updated the SVGRepo licensing info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
What is this PR for?
Add hierarchy icon to queue node
icon from svgrepo which is MIT License
What type of PR is it?
What is the Jira issue?
YUNIKORN-2571
Screenshots (if appropriate)