Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2571] Add hierarchy icon to queue node #189

Closed
wants to merge 3 commits into from

Conversation

doupache
Copy link
Contributor

@doupache doupache commented Apr 19, 2024

What is this PR for?

Add hierarchy icon to queue node
icon from svgrepo which is MIT License

image

What type of PR is it?

  • - Improvement

What is the Jira issue?

YUNIKORN-2571

Screenshots (if appropriate)

image

Copy link

@baconYao baconYao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestion, thanks.

src/app/components/queue-v2/queues-v2.component.ts Outdated Show resolved Hide resolved
@ryankert01
Copy link
Contributor

+1, Nice icon.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.77%. Comparing base (e4bc274) to head (62834b7).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   38.77%   38.77%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           19       19           
  Misses         27       27           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenyulin0719 chenyulin0719 requested a review from wilfred-s April 22, 2024 01:11
@chenyulin0719
Copy link
Contributor

Hi @wilfred-s, @craigcondit,

What else we need to do to include the image from MIT license?

The MIT lincese says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

@wilfred-s
Copy link
Contributor

wilfred-s commented Apr 22, 2024

We need to add a couple of lines to the License file. Like we did in the k8shim LICENSE file:

--------------------------------------------------------------------------------
This product bundles various third-party components under other open source
licenses. This section summarizes those components and their licenses.

MIT License
------------
src/assets/images/hierarchy.svg

Besides that the repo has the following comment:
https://www.svgrepo.com/page/licensing/
So we can add a text to the about box which we already need for our 3rd party licenses to make them easily accessible. This was doen in YUNIKORN-2448 so we should be able to piggy-back on that one

@doupache
Copy link
Contributor Author

I have updated the SVGRepo licensing info.
cc @wilfred-s

image

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants