Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates client starter code [Ready to merge] #296

Merged
merged 28 commits into from
Nov 16, 2022
Merged

Conversation

jpvajda
Copy link
Contributor

@jpvajda jpvajda commented Oct 4, 2022

  • This PR is an attempt to update this project to React 18 standards.
  • it also removes the yarn.lock file, as this seems to be focused on NPM not Yarn
  • Finally this is still WIP so please don't merge in just yet. 😉

Related PRs

#298
https://github.com/apollographql/odyssey/pull/544

@jpvajda jpvajda changed the title updates client starter code [Don updates client starter code [Dont Merge] Oct 4, 2022
@jpvajda
Copy link
Contributor Author

jpvajda commented Oct 28, 2022

@rkoron007 This work is done now! Just a note all the changed made here would also be needed to be made in the final code. is that something you could do ?

Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through and made a corresponding PR for updating the final code, I ran into some improvement on the way but please let me know if anything doesn't look good to you!

start/client/src/components/launch-tile.tsx Outdated Show resolved Hide resolved
start/client/src/components/launch-tile.tsx Outdated Show resolved Hide resolved
start/client/src/components/loading.tsx Outdated Show resolved Hide resolved
start/client/src/components/login-form.tsx Outdated Show resolved Hide resolved
start/client/src/index.tsx Outdated Show resolved Hide resolved
start/client/src/pages/cart.tsx Outdated Show resolved Hide resolved
start/client/src/pages/launch.tsx Outdated Show resolved Hide resolved
start/client/src/pages/launches.tsx Outdated Show resolved Hide resolved
start/client/src/pages/launches.tsx Outdated Show resolved Hide resolved
start/client/src/pages/profile.tsx Outdated Show resolved Hide resolved
@jpvajda
Copy link
Contributor Author

jpvajda commented Nov 8, 2022

@rkoron007 👋 I fixed all those suggestions and merged in your suggested commits.

@jpvajda
Copy link
Contributor Author

jpvajda commented Nov 9, 2022

@rkoron007 I fixed all those hidden comments, let me know if there is anything else. Thank you!

Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after the top-level package-lock.json file is removed :)

start/client/package.json Show resolved Hide resolved
@jpvajda
Copy link
Contributor Author

jpvajda commented Nov 10, 2022

@rkoron007 I removed the file! So this is ready to merge now?

@rkoron007
Copy link
Contributor

rkoron007 commented Nov 10, 2022

@jpvajda - we'll need to merge https://github.com/apollographql/odyssey/pull/544 and this one at the same time to ensure that the instructions match the starter code. So soon! But not quite yet.

@rkoron007 rkoron007 changed the title updates client starter code [Dont Merge] updates client starter code [Ready to merge] Nov 15, 2022
@rkoron007 rkoron007 merged commit 56ae434 into main Nov 16, 2022
@rkoron007 rkoron007 deleted the tutorial-improvements branch November 16, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-emotion has been replaced by @emotion/styled
2 participants