-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates client starter code [Ready to merge] #296
Conversation
@rkoron007 This work is done now! Just a note all the changed made here would also be needed to be made in the final code. is that something you could do ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through and made a corresponding PR for updating the final code, I ran into some improvement on the way but please let me know if anything doesn't look good to you!
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
@rkoron007 👋 I fixed all those suggestions and merged in your suggested commits. |
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
Co-authored-by: Rose M Koron <[email protected]>
@rkoron007 I fixed all those hidden comments, let me know if there is anything else. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after the top-level package-lock.json
file is removed :)
@rkoron007 I removed the file! So this is ready to merge now? |
@jpvajda - we'll need to merge https://github.com/apollographql/odyssey/pull/544 and this one at the same time to ensure that the instructions match the starter code. So soon! But not quite yet. |
…updates Updating the final code to match the starter code from PR #296
Related PRs
#298
https://github.com/apollographql/odyssey/pull/544