Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AS4 [Don't Merge] #298

Closed
wants to merge 13 commits into from
Closed

Upgrade to AS4 [Don't Merge] #298

wants to merge 13 commits into from

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Oct 13, 2022

I started this PR with the intention of it being narrowly scoped, but grabbed a number of cleanup opportunities along the way. Hopefully the individual commits are digestible (though even they aren't necessarily single-purpose).

This PR updates the Apollo Server dependency to v4. This incorporates the breaking changes required to migrate as well as various dependency upgrades and some cleanup

Related PRs

#296
https://github.com/apollographql/odyssey/pull/544
.

@jpvajda jpvajda changed the title Upgrade to AS4 Upgrade to AS4 [Don't Merge] Oct 17, 2022
@jpvajda
Copy link
Contributor

jpvajda commented Oct 17, 2022

Thanks @trevor-scheer !

I put Don't merge on this PR as I think we'll want to also finish the work up in these related PRs and also update the full stack tutorial odyssey course to focus on AS4.

  • Client Improvements [PR]
  • Suggestions for the Odyssey course. [PR]

@Trickfilm400
Copy link

Hi,

looks great so far 👍🏻 , when will the migration be finished?
(This PR would close my #347)

@mabuyo
Copy link
Contributor

mabuyo commented Aug 23, 2023

Hey there @Trickfilm400! Thanks for filing that issue and sorry about the delay. Unfortunately we're no longer maintaining this example repo or tutorial. For the most up-to-date content, we recommend checking out the Lift-off series to learn similar GraphQL + Apollo concepts. You can also find the complete code example in the final folder of this repo: https://github.com/apollographql/odyssey-lift-off-part4

Of course if you prefer to keep learning from this resource, you can clone the branch from this PR (trevor/as4) locally and learn from there.

Hope that helps! I'll also archive this repo with a message for clarity.

@mabuyo mabuyo closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants