-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update observability/telemetry overview pages #6563
Conversation
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 1 new, 0 changed, 0 removed
Build ID: 54a6911a7d270c0c410cfb53 URL: https://www.apollographql.com/docs/deploy-preview/54a6911a7d270c0c410cfb53 |
@Meschreiber, please consider creating a changeset entry in |
!docs set-base-branch main |
!docs set-base-branch main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed observability intro
Co-authored-by: Edward Huang <[email protected]>
Co-authored-by: Edward Huang <[email protected]>
Map GraphQL error data to OTel errors with the following configuration: | ||
|
||
```yaml title="router.yaml" showLineNumbers=false | ||
telemetry: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it seems the commit that adds these configs is causing Circle CI tests that validate configs to fail.
![image](https://private-user-images.githubusercontent.com/23219998/410120272-5c47f978-2be1-405b-add2-b189bfd8e1ea.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODE5MjYsIm5iZiI6MTczOTE4MTYyNiwicGF0aCI6Ii8yMzIxOTk5OC80MTAxMjAyNzItNWM0N2Y5NzgtMmJlMS00MDViLWFkZDItYjE4OWJmZDhlMWVhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEwMDAyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZhNzNiZDYwZmI2YjAzNmUzNjFiZDJlZGI3MjIzOTRkNWUxNjJhOWQ5YjJiMjE2ZjQxNTUyNzZhOTYzMjJmMjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QGvV6T-RnAKrGubyXtjLjpRioutVYO1QyrO5aGxD1OI)
When testing them in VS Code with router config awareness, they didn't throw any issues though. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How sensitive are the tests to whitespace? For example, this bit:
static: error
condition:
eq:
- true
- on_graphql_error: true
looks indented a bit more than the rest
@Mergifyio backport 1.x |
✅ Backports have been created
|
Co-authored-by: Edward Huang <[email protected]> Co-authored-by: Shane Myrick <[email protected]> (cherry picked from commit e5359ca) # Conflicts: # docs/source/reference/router/telemetry/instrumentation/standard-instruments.mdx
…6750) Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
This PR: