Skip to content

Commit

Permalink
Remove Disney Material
Browse files Browse the repository at this point in the history
  • Loading branch information
est77 committed Apr 16, 2020
1 parent 763a2f8 commit 1e8e30c
Show file tree
Hide file tree
Showing 48 changed files with 3 additions and 4,224 deletions.
25 changes: 0 additions & 25 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ option (WITH_BENCH "Build appleseed.bench"
option (WITH_TOOLS "Build appleseed tools" ON)
option (WITH_PYTHON2_BINDINGS "Build Python bindings for Python 2" ON)
option (WITH_PYTHON3_BINDINGS "Build Python bindings for Python 3" OFF)
option (WITH_DISNEY_MATERIAL "Build Disney material" OFF)
option (WITH_EMBREE "Include support for Embree intersection backend" OFF)
option (WITH_GPU "Build GPU support" OFF)
option (WITH_SPECTRAL_SUPPORT "Include support for spectral colors" ON)
Expand All @@ -147,7 +146,6 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Windows")
option (USE_FIND_PACKAGE_FOR_OCIO "Use find_package() for OpenColorIO library" OFF)
option (USE_FIND_PACKAGE_FOR_OIIO "Use find_package() for OpenImageIO library" OFF)
option (USE_FIND_PACKAGE_FOR_OSL "Use find_package() for OpenShadingLanguage library" OFF)
option (USE_FIND_PACKAGE_FOR_SEEXPR "Use find_package() for SeExpr library" OFF)
option (USE_FIND_PACKAGE_FOR_XERCES "Use find_package() for Xerces library" OFF)
option (USE_FIND_PACKAGE_FOR_ZLIB "Use find_package() for zlib library" OFF)
else ()
Expand All @@ -158,7 +156,6 @@ else ()
set (USE_FIND_PACKAGE_FOR_OIIO ON)
set (USE_FIND_PACKAGE_FOR_OSL ON)
set (USE_FIND_PACKAGE_FOR_PNG ON)
set (USE_FIND_PACKAGE_FOR_SEEXPR ON)
set (USE_FIND_PACKAGE_FOR_XERCES ON)
set (USE_FIND_PACKAGE_FOR_ZLIB ON)
endif ()
Expand Down Expand Up @@ -323,17 +320,6 @@ if (USE_FIND_PACKAGE_FOR_PNG)
find_package (PNG REQUIRED)
endif ()

if (WITH_DISNEY_MATERIAL)
set (APPLESEED_WITH_DISNEY_MATERIAL ON)
add_definitions (-DAPPLESEED_WITH_DISNEY_MATERIAL)
if (USE_FIND_PACKAGE_FOR_SEEXPR)
find_package (SeExpr REQUIRED)
if (WITH_STUDIO)
find_package (SeExprEditor REQUIRED)
endif ()
endif ()
endif ()

if (USE_FIND_PACKAGE_FOR_XERCES)
add_definitions (-DAPPLESEED_WITH_EXTERNAL_XERCES)
find_package (Xerces REQUIRED)
Expand Down Expand Up @@ -404,17 +390,6 @@ else ()
include_directories (${APPLESEED_DEPS_STAGE_DIR}/osl-debug/include)
endif ()

if (WITH_DISNEY_MATERIAL)
if (USE_FIND_PACKAGE_FOR_SEEXPR)
include_directories (${SEEXPR_INCLUDE_DIRS})
if (WITH_STUDIO)
include_directories (${SEEXPREDITOR_INCLUDE_DIRS})
endif ()
else ()
include_directories (${APPLESEED_DEPS_STAGE_DIR}/SeExpr-debug/include)
endif ()
endif ()

if (USE_FIND_PACKAGE_FOR_XERCES)
include_directories (${XERCES_INCLUDE_DIRS})
else ()
Expand Down
25 changes: 0 additions & 25 deletions THIRDPARTIES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1663,31 +1663,6 @@ License:
------------------------------------------------------------------------------


SeExpr
https://www.disneyanimation.com/technology/seexpr.html

License:


Copyright Disney Enterprises, Inc. All rights reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License
and the following modification to it: Section 6 Trademarks.
deleted and replaced with:

6. Trademarks. This License does not grant permission to use the
trade names, trademarks, service marks, or product names of the
Licensor and its affiliates, except as required for reproducing
the content of the NOTICE file.

You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0


------------------------------------------------------------------------------


Xerces-C++
https://xerces.apache.org/xerces-c/

Expand Down
8 changes: 0 additions & 8 deletions cmake/config/linux-gcc-clang.txt
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,6 @@ macro (link_against_osl target)
target_link_libraries (${target} ${OSL_EXEC_LIBRARY} ${OSL_COMP_LIBRARY} ${OSL_QUERY_LIBRARY})
endmacro ()

macro (link_against_seexpr target)
target_link_libraries (${target} ${SEEXPR_LIBRARIES})
endmacro ()

macro (link_against_seexpreditor target)
target_link_libraries (${target} ${SEEXPREDITOR_LIBRARIES})
endmacro ()

macro (link_against_xercesc target)
target_link_libraries (${target} ${XERCES_LIBRARIES})
endmacro ()
Expand Down
8 changes: 0 additions & 8 deletions cmake/config/mac-clang.txt
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,6 @@ macro (link_against_osl target)
target_link_libraries (${target} ${OSL_EXEC_LIBRARY} ${OSL_COMP_LIBRARY} ${OSL_QUERY_LIBRARY})
endmacro ()

macro (link_against_seexpr target)
target_link_libraries (${target} ${SEEXPR_LIBRARIES})
endmacro ()

macro (link_against_seexpreditor target)
target_link_libraries (${target} ${SEEXPREDITOR_LIBRARIES})
endmacro ()

macro (link_against_xercesc target)
target_link_libraries (${target} ${XERCES_LIBRARIES})
endmacro ()
Expand Down
22 changes: 0 additions & 22 deletions cmake/config/win-vs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -351,28 +351,6 @@ macro (link_against_osl target)
endif ()
endmacro ()

macro (link_against_seexpr target)
if (USE_FIND_PACKAGE_FOR_SEEXPR)
target_link_libraries (${target} ${SEEXPR_LIBRARIES})
else ()
target_link_libraries (${target}
debug ${APPLESEED_DEPS_STAGE_DIR}/seexpr-debug/lib/SeExpr.lib
optimized ${APPLESEED_DEPS_STAGE_DIR}/seexpr-release/lib/SeExpr.lib
)
endif ()
endmacro ()

macro (link_against_seexpreditor target)
if (USE_FIND_PACKAGE_FOR_SEEXPR)
target_link_libraries (${target} ${SEEXPREDITOR_LIBRARIES})
else ()
target_link_libraries (${target}
debug ${APPLESEED_DEPS_STAGE_DIR}/seexpr-debug/lib/SeExprEditor.lib
optimized ${APPLESEED_DEPS_STAGE_DIR}/seexpr-release/lib/SeExprEditor.lib
)
endif ()
endmacro ()

macro (link_against_xercesc target)
if (USE_FIND_PACKAGE_FOR_XERCES)
target_link_libraries (${target} ${XERCES_LIBRARIES})
Expand Down
64 changes: 0 additions & 64 deletions cmake/modules/FindSeExpr.cmake

This file was deleted.

64 changes: 0 additions & 64 deletions cmake/modules/FindSeExprEditor.cmake

This file was deleted.

8 changes: 0 additions & 8 deletions sandbox/seexpr/clouds/blue_clouds.se

This file was deleted.

7 changes: 0 additions & 7 deletions sandbox/seexpr/geometric/checkers.se

This file was deleted.

8 changes: 0 additions & 8 deletions sandbox/seexpr/geometric/dots.se

This file was deleted.

1 change: 0 additions & 1 deletion sandbox/seexpr/gradients/horizontal.se

This file was deleted.

1 change: 0 additions & 1 deletion sandbox/seexpr/gradients/vertical.se

This file was deleted.

5 changes: 0 additions & 5 deletions sandbox/seexpr/noise/fbm.se

This file was deleted.

5 changes: 0 additions & 5 deletions sandbox/seexpr/noise/noise.se

This file was deleted.

8 changes: 0 additions & 8 deletions sandbox/seexpr/noise/turbulence.se

This file was deleted.

64 changes: 0 additions & 64 deletions sandbox/share/cmake/Modules/FindSeExpr.cmake

This file was deleted.

Loading

2 comments on commit 1e8e30c

@danfe
Copy link
Contributor

@danfe danfe commented on 1e8e30c Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit log does not explain the reason for this change. Could you explain why was it removed?

@est77
Copy link
Member Author

@est77 est77 commented on 1e8e30c Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a legacy material model, only used inside appleseed.studio and only for some demo scenes.
The OSL implementation of this model is better and supported in all appleseed plugins.

Please sign in to comment.