Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images added in the Explore top destinations section #586 #705

Closed
wants to merge 1 commit into from
Closed

Images added in the Explore top destinations section #586 #705

wants to merge 1 commit into from

Conversation

nidhipai78
Copy link
Contributor

Title and Issue number

Title : Images added in the Explore top destinations section

Issue No. : #586

Code Stack : HTML | CSS

Close #586

Description

Images for each of the destinations are added in the explore top destinations section. Along with it, the background of each card is added with the same image.

Video/Screenshots

image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

Each images get slided downwards when clicked on it.

Are you contributing under any Open-source programme?
I am a GSSOC'24 Contributor

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 33f4f36
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/665d66541c625d00083c0042
😎 Deploy Preview https://deploy-preview-705--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidhipai78 this PR has merge conflicts .I would like to suggest you to submit a new PR making a branch in your forked repo (updating the branch at first)& push all of your changes there so that this will remove all the conflicts .
I am closing this PR for now but waiting for your PR.

@apu52 apu52 closed this Jun 5, 2024
@apu52 apu52 added the wontfix This will not be worked on label Jun 5, 2024
@nidhipai78 nidhipai78 deleted the images branch June 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:No images in the "Explore Top Destination" section
2 participants