Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change workflow to use a reusable workflow for building the Go release #23

Closed
wants to merge 2 commits into from

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Apr 5, 2024

Changes introduced with this PR

Modify the build to use the arcaflow-reusable-workflows/go_release.yaml reusable workflow.


By contributing to this repository, I agree to the contribution guidelines.

@webbnh webbnh self-assigned this Apr 5, 2024
@webbnh
Copy link
Contributor Author

webbnh commented Apr 5, 2024

@jaredoconnell, the build appears to have run fine, but GH is still looking for a job from the old build (which isn't going to run, let alone report status), so, once this is approved, you'll need to use the Admin override to merge it.

@webbnh webbnh marked this pull request as draft April 9, 2024 22:19
@webbnh

This comment was marked as outdated.

@webbnh webbnh marked this pull request as ready for review April 10, 2024 16:23
@webbnh webbnh force-pushed the reuseable_release branch from 7702460 to 084def3 Compare April 10, 2024 16:27
@webbnh webbnh requested review from dbutenhof and mfleader April 10, 2024 17:08
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it ought to be pretty straightforward ...

@jaredoconnell
Copy link
Contributor

This appears to have been merged, but not closed due to a Github glitch.

@webbnh webbnh deleted the reuseable_release branch April 10, 2024 19:27
webbnh added a commit to webbnh/arcaflow-docsgen that referenced this pull request Apr 10, 2024
arcalot#23)

* Change workflow to use a reusable workflow for building the Go release

* Pass Go version as an input to sub-workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants