-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change build to use reusable workflows #169
Conversation
44f8a44
to
dd7d416
Compare
Now that arcalot/arcaflow-reusable-workflows#16 is merged, we're ready to try this. |
- rename the workflow file to the conventional extension - switch to using reusable workflows for - lint and test - building the release - building the Python wheel
dd7d416
to
59c93b7
Compare
This PR is having the same problem as arcalot/arcaflow-docsgen#23 (comment) with the "release" check. Also, it's having the same problem that arcalot/arcaflow-docsgen#22 had, with the organization variable values not being available in the called workflow. Unfortunately, unlike the Go release workflow which blunders on without it, the Python release workflow dies. So, @jaredoconnell, unless someone has an objection, you should use your Admin override to merge it; and, if it doesn't run properly after that, we'll fix it then. |
Now that I think of it, I think we need to pass the org variables in from the calling workflow, and have them as input variables in the reusable workflows. I now remember Justin running into this with secrets. |
Org variables, environment variables, inputs, and secrets are all separate, individual things with individual handling (and frustrations). Org variables do work, once the workflow is merged in -- we already have evidence of that in I suspect that passing the values of the org variables as inputs would get us past the problem of not being able to test prior to merging (and, it would better encapsulate/uncouple the reusable workflows), so it wouldn't be a bad thing. I had contemplated using that approach, but I s'pose I'll retool all three of them. |
This PR is now back in draft awaiting arcalot/arcaflow-reusable-workflows#17. |
21fe162
to
f9258b6
Compare
f9258b6
to
ecdc502
Compare
This PR has been superseded by #171, in the hopes that, because that's pulling from a branch in the upstream repo, it will test cleanly. |
Changes introduced with this PR
This PR reworks the build workflow
By contributing to this repository, I agree to the contribution guidelines.