Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable workflows #171

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Reusable workflows #171

merged 2 commits into from
Apr 12, 2024

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Apr 12, 2024

Changes introduced with this PR

This PR supersedes #169: it's the same commits, but this PR is pulling from a branch in the upstream repo rather than from my fork, in the hopes that this will produce a clean test run, since GitHub seems highly resistant to allowing the values of configuration variables to leak outside the organization.

This PR reworks the build workflow

  • rename the workflow file to the conventional extension
  • switch to using reusable workflows for
    • lint and test
    • building the release
    • building the Python wheel

By contributing to this repository, I agree to the contribution guidelines.

- rename the workflow file to the conventional extension
- switch to using reusable workflows for
  - lint and test
  - building the release
  - building the Python wheel
@webbnh webbnh self-assigned this Apr 12, 2024
@webbnh webbnh force-pushed the reusable_workflows branch from ecdc502 to 3339f11 Compare April 12, 2024 17:53
@webbnh webbnh marked this pull request as ready for review April 12, 2024 18:43
@webbnh
Copy link
Contributor Author

webbnh commented Apr 12, 2024

This PR is now ready for review: it appears to build successfully both for the PR and for a tag. However, the last PR status check, release, it's passing, because the workflow no longer reports this...@jaredoconnell, could you remove this requirement for the repo?

@webbnh webbnh merged commit eccf155 into main Apr 12, 2024
10 checks passed
@webbnh webbnh deleted the reusable_workflows branch April 12, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants