Plugin provider atp race condition #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Although three separate lock regions in the same function sure looks odd, without reading all the called code (which I'm not inclined to do now), I can't say it's excessive or unnecessary.
In any case, yeah, if creating the ATP client is a potential race, you've clearly serialized it within one of the lock regions... 😆
webbnh
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This moves a line up into a slot in the code at which the mutex is locked. That's it.
That appears to fix the race condition.
By contributing to this repository, I agree to the contribution guidelines.