Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin provider atp race condition #172

Merged
merged 36 commits into from
Apr 17, 2024
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
ffb2827
Progress towards adding function expressions to the engine
jaredoconnell Feb 5, 2024
3b498cf
Added function support
jaredoconnell Feb 7, 2024
c36109c
Fixes.
jaredoconnell Feb 7, 2024
cc2a01e
Added workflow test cases with more complex expressions
jaredoconnell Feb 9, 2024
d872890
Addressed review feedback
jaredoconnell Feb 13, 2024
41137ae
Remove unnecessary reference to the function names in descriptions
jaredoconnell Feb 13, 2024
4c7f591
More description changes
jaredoconnell Feb 13, 2024
6c6b728
Manually add special cases to prevent platform-specific behavior
jaredoconnell Feb 14, 2024
3ffb44b
Added negative zeros to test cases
jaredoconnell Feb 14, 2024
f1500e4
Address review comments
jaredoconnell Feb 14, 2024
1422625
Merge branch 'main' into function-support
jaredoconnell Feb 14, 2024
1f491cd
Change case
jaredoconnell Feb 14, 2024
ad7bbaf
Address review comments
jaredoconnell Feb 15, 2024
b422120
Address review comments
jaredoconnell Feb 16, 2024
453a458
Fix linting error and address review comment.
jaredoconnell Feb 16, 2024
b01e7d8
Change descriptions for functions
jaredoconnell Feb 16, 2024
912c1b5
Address review comment
jaredoconnell Feb 16, 2024
3b3ee56
Added namespaced scopes for step namespaces in input
jaredoconnell Feb 21, 2024
05c45a2
Use default namespace constant
jaredoconnell Feb 22, 2024
ab751ad
Apply scopes from sub-workflows
jaredoconnell Feb 22, 2024
6cbcd4e
Merge branch 'main' into namespaced-scopes
jaredoconnell Mar 14, 2024
45cc29a
Update invalid serialization detector for changes in SDK
jaredoconnell Mar 14, 2024
f8480a8
Fix linting errors
jaredoconnell Mar 14, 2024
5fb8e94
Improved code and added initial tests for namespaced scopes
jaredoconnell Mar 22, 2024
52ede8c
Added unit tests for new ApplyScope functions
jaredoconnell Mar 29, 2024
1bd2e22
Added integration tests for namespaced scoped workflows
jaredoconnell Apr 3, 2024
f2875cf
Added namespaces for referenced items in scopes
jaredoconnell Apr 5, 2024
5b6d279
Merge branch 'main' into namespaced-scopes
jaredoconnell Apr 5, 2024
e5adf71
Upgrade to go SDK pre-release
jaredoconnell Apr 11, 2024
77c91db
Merge branch 'main' into namespaced-scopes
jaredoconnell Apr 12, 2024
e0555d8
Addressed review comments
jaredoconnell Apr 16, 2024
3dd60af
Clarify stage IDs in comment examples
jaredoconnell Apr 16, 2024
3cf14b6
Addressed review comments
jaredoconnell Apr 16, 2024
eee729b
Fixed race condition for atp client field
jaredoconnell Apr 17, 2024
8feefc1
Merge branch 'main' into plugin-provider-atp-race-condition
jaredoconnell Apr 17, 2024
32d8178
Move instantiation out of locked region
jaredoconnell Apr 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/step/plugin/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -886,10 +886,12 @@ func (r *runningStep) deployStage() (deployer.Plugin, error) {

func (r *runningStep) startStage(container deployer.Plugin) error {
r.logger.Debugf("Starting stage for step %s/%s", r.runID, r.pluginStepID)
atpClient := atp.NewClientWithLogger(container, r.logger)
r.lock.Lock()
previousStage := string(r.currentStage)
r.currentStage = StageIDStarting
inputRecievedEarly := false
r.atpClient = atpClient

var runInput any
select {
Expand Down Expand Up @@ -940,7 +942,6 @@ func (r *runningStep) startStage(container deployer.Plugin) error {
return fmt.Errorf("step closed while waiting for run configuration")
}
}
r.atpClient = atp.NewClientWithLogger(container, r.logger)

inputSchema, err := r.atpClient.ReadSchema()
if err != nil {
Expand Down
Loading