Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list sub-type type resolution #141

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

This fixes the use of a dict in list and potentially other complex types in a list.


By contributing to this repository, I agree to the contribution guidelines.

webbnh

This comment was marked as resolved.

@dustinblack dustinblack linked an issue Nov 8, 2024 that may be closed by this pull request
@jaredoconnell
Copy link
Contributor Author

LGTM.

Does the update to the test fail on the current code (I assume that it passes on the proposed code...)? (I.e., does it prove that you've addressed the/a problem?)

The one line change to the test case created the exact error that Dustin encountered in the plugin. Since the tests are passing now, that means it addressed it.

@jaredoconnell jaredoconnell merged commit d4b7c9f into main Nov 8, 2024
4 checks passed
@jaredoconnell jaredoconnell deleted the fix-list-type-resolution branch November 8, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to define a list of dictionaries in a schema dataclass
4 participants