-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: voicekick command #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! However, probably need to add a permission check of some kind
really appreciate the en_kawaii translations lol |
modules/util.rb
Outdated
usage: '.voicekick [user] [channel]', | ||
min_args: 1, | ||
max_args: 2, | ||
required_permissions: %i[manage_users] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, discordrb only supports setting one, global string for this feature, which means localization does not work.
so permission checks usually happen manually (example).
How's Looks like just adding the param does the job, bot behaved as intended immediately. |
the issue is that the message it responds with doesn't get localized because of CommandBot jank |
yup- I see it now |
the other issue is that qbot ignores commands from other bots. which will be more difficult to resolve |
ooo yikes |
Line 32 in 46be006
|
The original intention was to entirely remove a user from voice, but that isn't possible with discordrb; see shardlab/discordrb#185
This version moves the user to a specified channel if one is set, to the afk channel if one is set, or throws a failure message otherwise.