Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the fullformatedtime capability #195

Closed
wants to merge 4 commits into from

Conversation

Saad-Imtiaz
Copy link

Add the Google API format that is 2013-02-14T13:15:03.
This format type can be accessed by using fullformatedtime().

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Memory usage change @ 73ab371

Board flash % RAM for global variables %
esp8266:esp8266:huzzah N/A N/A N/A N/A
Click for full report table
Board examples/Advanced
flash
% examples/Advanced
RAM for global variables
% examples/Basic
flash
% examples/Basic
RAM for global variables
%
esp8266:esp8266:huzzah N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV
Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%
esp8266:esp8266:huzzah,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 10, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request @Saad-Imtiaz. I see we have a previous proposal for the addition of this getFormattedDate function: #119

The difference in your proposal is that the function takes an argument that allows it to be used as a converter for arbitrary input. I feel that such a conversion functionality is out of scope for this library and would be better provided by a library dedicated to such things (perhaps even just using strftime directly).

So I will close this as essentially a duplicate of #119


By the way, I noticed that you introduced a huge quantity of unrelated and harmful changes in addition to the reasonable proposal of the addition of the getFormattedDate function. Those unrelated changes made the pull request very difficult to evaluate and would not have been accepted even if the primary proposal was accepted. I recommend you take more care in the future when you make contributions to open source software projects. You should carefully check the diff to make sure your commits only make the intended changes.

One of the serious problems in this pull request is that you changed the line endings in some files from LF to CRLF. LF is generally the standard line ending in any software project. You should check the settings of your text editor/IDE to see if it is configured to use CRLF so that you can avoid this problem in the future.

@per1234 per1234 self-assigned this Sep 10, 2023
@per1234 per1234 closed this Sep 10, 2023
@per1234 per1234 added the conclusion: declined Will not be worked on label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants