Feature/bootstrapping #35
Conversation
|
@aruizs I think there might be a problem with sonar for Ubuntu? |
There was a problem hiding this comment.
First, I apologize for the long delay.
I've just fixed the sonnar issue in the ubuntu CI action. (Please rebase with the main branch)
I guess the MAC execution could be fixed when you add the commented stuff. (I don't have either a Mac for testing it directly)
| cacheFile.close(); | ||
| m_features = loadFeatures(features_buffer.str()); | ||
| } else | ||
| std::cout << "Could not open cache file '" << m_cacheFilePath << "' for reading." << std::endl; |
There was a problem hiding this comment.
There is a missing return in this case. Otherwise the periodic task is launched and the instance is marked as initialized.
| << std::endl; | ||
| return; | ||
| std::cerr << "Attempted to initialize an Unleash Client instance without server response." << std::endl; | ||
| std::ifstream cacheFile(m_cacheFilePath, std::fstream::in); |
There was a problem hiding this comment.
I think we could avoid to load the file if the cacheFile is not set or disable the "Could not open cache file" comment at least.
Hey @aruizs, due to changes that happened on our fork and the fact that I do not have write access to this one, I found it easier to open a new PR instead of the old one.
This one is based on your latest main branch