-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bootstrapping #35
Open
bolomcs50
wants to merge
8
commits into
aruizs:main
Choose a base branch
from
wingtra:feature/bootstrapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−14
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6e7f79f
Read and write file
bolomcs50 6ac243d
cleanup
bolomcs50 1cb3347
android fix 1
bolomcs50 210ba61
update url
bolomcs50 97ab0cc
make context a struct
bolomcs50 cd1c247
Make testing flag specific
bolomcs50 0954dde
Update CI workflows
bolomcs50 94bfb6d
Fix option exposure
bolomcs50 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[submodule "client-specification"] | ||
path = client-specification | ||
url = git@github.com:Unleash/client-specification.git | ||
url = https://github.com/Unleash/client-specification.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,8 @@ | |
#include "unleash/api/cprclient.h" | ||
#include "unleash/strategies/strategy.h" | ||
#include <nlohmann/json.hpp> | ||
#include <fstream> | ||
#include <sstream> | ||
|
||
namespace unleash { | ||
|
||
|
@@ -45,6 +47,11 @@ UnleashClientBuilder &UnleashClientBuilder::registration(bool registration) { | |
return *this; | ||
} | ||
|
||
UnleashClientBuilder &UnleashClientBuilder::cacheFilePath(std::string cacheFilePath) { | ||
unleashClient.m_cacheFilePath = std::move(cacheFilePath); | ||
return *this; | ||
} | ||
|
||
void UnleashClient::initializeClient() { | ||
if (!m_isInitialized) { | ||
// Set-up Unleash API client | ||
|
@@ -61,12 +68,19 @@ void UnleashClient::initializeClient() { | |
// Initial fetch of feature flags | ||
auto apiFeatures = m_apiClient->features(); | ||
if (apiFeatures.empty()) { | ||
std::cerr << "Attempted to initialize an Unleash Client instance " | ||
"without server response." | ||
<< std::endl; | ||
return; | ||
std::cerr << "Attempted to initialize an Unleash Client instance without server response." << std::endl; | ||
std::ifstream cacheFile(m_cacheFilePath, std::fstream::in); | ||
if (cacheFile.is_open()){ | ||
std::cout << "Reading configuration from cached file " << m_cacheFilePath << std::endl; | ||
std::stringstream features_buffer; | ||
features_buffer << cacheFile.rdbuf(); | ||
cacheFile.close(); | ||
m_features = loadFeatures(features_buffer.str()); | ||
} else | ||
std::cout << "Could not open cache file '" << m_cacheFilePath << "' for reading." << std::endl; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a missing |
||
} else { | ||
m_features = loadFeatures(apiFeatures); | ||
} | ||
m_features = loadFeatures(apiFeatures); | ||
m_thread = std::thread(&UnleashClient::periodicTask, this); | ||
m_isInitialized = true; | ||
} else { | ||
|
@@ -86,7 +100,22 @@ void UnleashClient::periodicTask() { | |
if (globalTimer >= m_refreshInterval) { | ||
globalTimer = 0; | ||
auto features_response = m_apiClient->features(); | ||
if (!features_response.empty()) m_features = loadFeatures(features_response); | ||
if (!features_response.empty()){ | ||
std::ofstream cacheFile(m_cacheFilePath); | ||
if (cacheFile.is_open()) | ||
cacheFile << features_response; | ||
cacheFile.close(); | ||
m_features = loadFeatures(features_response); | ||
} else { | ||
std::ifstream cacheFile(m_cacheFilePath); | ||
if(cacheFile.is_open()){ | ||
std::stringstream features_buffer; | ||
features_buffer << cacheFile.rdbuf(); | ||
cacheFile.close(); | ||
m_features = loadFeatures(features_buffer.str()); | ||
|
||
} | ||
} | ||
} | ||
} | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could avoid to load the file if the
cacheFile
is not set or disable the "Could not open cache file" comment at least.