Detect out-of-sync lock file in the pr builder #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavinduLakshan
requested review from
brionmario,
NipuniBhagya,
inthirakumaaran and
jeradrutnam
as code owners
pavinduLakshan
force-pushed
the
improve_pr_builder
branch
from
d6b450c to
13ecff0
Compare
brionmario
reviewed
Jul 30, 2024
| @@ -38,6 +38,15 @@ jobs: | |||
| uses: actions/setup-node@v1 | |||
| with: | |||
| node-version: ${{ matrix.node-version }} | |||
|
|
|||
| - name: Install dependencies | |||
There was a problem hiding this comment.
IMO, the proper fix here would be to remove the prebuild script that installs packages and do the install explicitly.
As a temp workaround, we can do a yarn install --frozen-lockfile before the yarn build
- name: Build
run: |
+ yarn install --frozen-lockfile
yarn buildThere was a problem hiding this comment.
IMO, the proper fix here would be to remove the prebuild script that installs packages and do the install explicitly.
Removing the prebuild script would cause inconsistent lock files being used to package the release artifact, wouldn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related issues