Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect out-of-sync lock file in the pr builder #238

Closed
wants to merge 6 commits into from
Closed

Detect out-of-sync lock file in the pr builder #238

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21d9961
Detect out-of-sync lock file in the pr builder
pavinduLakshan Jul 29, 2024
f413b61
Prevent git diff output printed in pr builder
pavinduLakshan Jul 29, 2024
13ecff0
Update error message
pavinduLakshan Jul 29, 2024
dfb6fbc
Update error condition
pavinduLakshan Jul 29, 2024
d426aae
Discard changes to package.json
pavinduLakshan Jul 29, 2024
5095d24
Show modified files
pavinduLakshan Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/pr-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- name: Install dependencies
Copy link
Member

@brionmario brionmario Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the proper fix here would be to remove the prebuild script that installs packages and do the install explicitly.

As a temp workaround, we can do a yarn install --frozen-lockfile before the yarn build

    - name: Build
      run: |
+       yarn install --frozen-lockfile
        yarn build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the proper fix here would be to remove the prebuild script that installs packages and do the install explicitly.

Removing the prebuild script would cause inconsistent lock files being used to package the release artifact, wouldn't it?

run: |
yarn
if ! git diff --exit-code > /dev/null 2>&1; then
echo "ERR! There are modified files after running yarn."
git status -s
exit 1
fi

- name: Build
run: |
Expand Down
Loading