Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test rules from JSON schema #15627

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Remove test rules from JSON schema #15627

merged 1 commit into from
Jan 24, 2025
+1 −2

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Jan 21, 2025 •
edited
Loading

Closes: #15707

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser
Copy link
Member

I'm not sure this is the right fix but I can see how any other fix is annoying.

The reason why I don't think we should enable testing in ruff_dev is because users can't select the testing rules and, therefore, they shouldn't be in the json schema. If they currently are, then that's a bug and we should remove them.

@dhruvmanila
Copy link
Member Author

I'm not sure this is the right fix but I can see how any other fix is annoying.

The reason why I don't think we should enable testing in ruff_dev is because users can't select the testing rules and, therefore, they shouldn't be in the json schema. If they currently are, then that's a bug and we should remove them.

Oh, right. That makes more sense. Thanks for catching that, I've updated the PR.

@dhruvmanila dhruvmanila changed the title Use ruff_linter with the "test-rules" features in ruff_dev Remove test rules from JSON schema Jan 21, 2025
@dhruvmanila dhruvmanila mentioned this pull request Jan 24, 2025
Closed
@dhruvmanila dhruvmanila merged commit 9384ba4 into main Jan 24, 2025
21 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/test-rules branch January 24, 2025 04:48
InSyncWithFoo added a commit to InSyncWithFoo/ruff that referenced this pull request Jan 24, 2025
@InSyncWithFoo
Revert astral-sh#15627
aeb4fd4
@InSyncWithFoo InSyncWithFoo mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_generate_json_schema failing as of 0.9.2
2 participants
@dhruvmanila @MichaReiser