-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sequencer): refactor app #1819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. A couple of minor suggestions though.
Fraser999
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docker-build
used to trigger docker builds on PRs
refactor
code refactoring or maintainence
sequencer
pertaining to the astria-sequencer crate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
<prepare/process>_proposal_execute_transactions
methods.Background
These methods previously contained a lot of shared code. This is meant to eliminate this code duplication and also make the steps that are happening in the proposals clearer and easier to understand.
Changes
prepare_proposal_execute_transactions
toprepare_proposal_tx_execution
to better represent that this is the execution step of the largerprepare_proposal
method.process_proposal_execute_transactions
toprocess_proposal_tx_execution
.Proposal
containing information necessary for eitherPrepare
orProcess
.Testing
Passing all tests.
Changelogs
No updates required
Related Issues
closes #1785