Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend nasdf #3145

Merged
merged 6 commits into from
Sep 10, 2023
Merged

Extend nasdf #3145

merged 6 commits into from
Sep 10, 2023

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Aug 31, 2023

Description

Minor NASDF extension that helps to install Nyxt on GNU/Linux and, in particular, as a Flatpak.

Appdata files contain metadata that is used by software centers. It dictates, for instance, how Nyxt is displayed at https://flathub.org/apps/engineer.atlas.Nyxt.

Checklist:

Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.

  • Git hygiene:
    • I have pulled from master before submitting this PR
    • There are no merge conflicts.
  • I've added the new dependencies as:
    • ASDF dependencies,
    • Git submodules,
      cd /path/to/nyxt/checkout
      git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser
    • and Guix dependencies.
  • My code follows the style guidelines for Common Lisp code. See:
  • I have performed a self-review of my own code.
  • My code has been reviewed by at least one peer. (The peer review to approve a PR counts. The reviewer must download and test the code.)
  • Documentation:
    • All my code has docstrings and :documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)
    • I have updated the existing documentation to match my changes.
    • I have commented my code in hard-to-understand areas.
    • I have updated the changelog.lisp with my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).
      • Changelog update should be a separate commit.
    • I have added a migration.lisp entry for all compatibility-breaking changes.
    • (If this changes something about the features showcased on Nyxt website) I have these changes described in the new/existing article at Nyxt website or will notify one of maintainters to do so.
  • Compilation and tests:
    • My changes generate no new warnings.
    • I have added tests that prove my fix is effective or that my feature works. (If possible.)
    • I ran the tests locally ((asdf:test-system :nyxt) and (asdf:test-system :nyxt/gi-gtk)) and they pass.

assets/nyxt.metainfo.xml Outdated Show resolved Hide resolved
assets/nyxt.metainfo.xml Outdated Show resolved Hide resolved
@aadcg aadcg merged commit 68ea8c0 into master Sep 10, 2023
2 checks passed
@aadcg aadcg deleted the extend-nasdf branch September 10, 2023 21:27
@aadcg
Copy link
Member Author

aadcg commented Sep 10, 2023

Merged since it needs to land for the next release. Pending topics (#3157) moved to issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants