Patch 8 - check but is redundant? #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eProsima TSC report 2021 Signed-off-by: Iker Luengo <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
No change to the content at all. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
In particular, the raw HTML "<img>" tag doesn't seem to support width and height in the GitHub Markdown rendering. Just remove these extra tags. Signed-off-by: Chris Lalancette <[email protected]>
They need to be links to the raw URLs to be rendered in markdown correctly. Signed-off-by: Chris Lalancette <[email protected]>
…srf#65) Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Joe Speed <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
This unfortunately doesn't render properly in GitHub pages. Signed-off-by: Chris Lalancette <[email protected]>
Also do the REP-2004 update. Signed-off-by: Chris Lalancette <[email protected]>
* Fix typos Signed-off-by: Audrow Nash <[email protected]> * Update quality declaration URL Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
* Re-running Galactic notebooks with slight modifications for Humble data. Still need to critically review the results to make sure everything checks out. Co-authored-by: kscottz <[email protected]>
Signed-off-by: Iker Luengo <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
After reading the report, fix some typos and other inconsistencies. Fix some links to external resources. Also add in the Appendix as we refer to it several times. Signed-off-by: Chris Lalancette <[email protected]>
… updated plot ranges.
Updated dates on data to correct date, made nb easier to change date,…
Humble additions
Signed-off-by: Chris Lalancette <[email protected]>
Humble additions
* fixed typos and minor omissions Co-authored-by: Chris Lalancette <[email protected]>
Adding the text to go with plots and quotes.
Formatting fix.
Formatting test.
Proof reading, formatting, consistency.
Uhg, open quote fix.
Adding more quotes.
Fill in executive summary, Fast DDS to Fast RTPS
@clalancette CYCLONEDDS_QUALITY_DECLARATION.md#performance-4iv already describes the performance testing. So at a minimum should say "manual performance testing" If is ok, I also added what @eboasson told me previously that nightly performance regression testing is part of the Eclipse Cyclone DDS and OpenSplice DDS interoperability testing run on internal servers. Open Robotics build farm also does nightly performance testing that includes the DDS implementations and rmws. Should that be referenced in the report's comments for both implementations? Please see https://github.com/eclipse-cyclonedds/cyclonedds/blob/master/CYCLONEDDS_QUALITY_DECLARATION.md#performance-4iv and eclipse-cyclonedds/cyclonedds#987
added following after chatting with @clalancette: Open Robotics build farm does nightly performance testing with both DDS implementations and rmw packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub suggested I compare and merge, but I think you already have these edits in other PR? I'll close if so