Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .NET Framework 4.6.2 instead of 4.5.2 #687

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 20, 2023

Changes

With the lowest .NET framework currently supported being 4.6.2, it makes sense to remove our 4.5.2 support and only ship .NET Standard 2.0, which supports 4.6.1 and above.

However, as mentioned here, I makes sense to keep an explicit target for .NET 4.6.2 to improve compatibility.

CONSIDER adding a target for net462 when you're offering a netstandard2.0 target.

Using .NET Standard 2.0 from .NET Framework has some issues that were addressed in .NET Framework 4.7.2. 
You can improve the experience for developers that are still on .NET Framework 4.6.2 - 4.7.1 by offering them a binary that's built for .NET Framework 4.6.2.

References

https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-framework

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner December 20, 2023 19:59
@frederikprijck frederikprijck enabled auto-merge (squash) December 20, 2023 20:05
@frederikprijck frederikprijck changed the title Target .NET Framework 4.6.2 instead of 4.5.2 Only target .NET Standard 2.0 and drop .NET Framework 4.5.2 Dec 20, 2023
@Hawxy
Copy link
Contributor

Hawxy commented Dec 21, 2023

Heads up that the recommendation is to keep at least a net462 target if using .NET Standard 2.0. Although 4.6.2 "supports" .NET Standard 2.0, it can randomly break and cause dependency resolution issues. See https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/cross-platform-targeting

CONSIDER adding a target for net462 when you're offering a netstandard2.0 target.

Using .NET Standard 2.0 from .NET Framework has some issues that were addressed in .NET Framework 4.7.2. 
You can improve the experience for developers that are still on .NET Framework 4.6.2 - 4.7.1 by offering them a binary that's built for .NET Framework 4.6.2.

@frederikprijck
Copy link
Member Author

That's actually good to know, will revert the last commit.

Thanks @Hawxy

@frederikprijck frederikprijck changed the title Only target .NET Standard 2.0 and drop .NET Framework 4.5.2 Target .NET Framework 4.6.2 instead of 4.5.2 Dec 21, 2023
@frederikprijck frederikprijck enabled auto-merge (squash) December 21, 2023 06:14
@frederikprijck frederikprijck merged commit f7d767e into master Dec 21, 2023
12 checks passed
@frederikprijck frederikprijck deleted the chore/bump-dotnet-framework branch December 21, 2023 13:20
@frederikprijck frederikprijck mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants