Merge pull request #2073 from authzed/fix-serve-devtools-command

Fix serve-devtools command and flags
authzed · Sep 20, 2024 · 09492d7 · 09492d7
2 parents 66ee7e2 + 61742e4
commit 09492d7
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/pkg/cmd/devtools.go b/pkg/cmd/devtools.go
@@ -17,6 +17,7 @@ import (
 	"github.com/jzelinskie/cobrautil/v2"
 	"github.com/jzelinskie/cobrautil/v2/cobragrpc"
 	"github.com/jzelinskie/cobrautil/v2/cobrahttp"
+	"github.com/jzelinskie/cobrautil/v2/cobraotel"
 	"github.com/jzelinskie/stringz"
 	"github.com/spf13/cobra"
 	"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc"
@@ -28,6 +29,7 @@ import (
 	v0svc "github.com/authzed/spicedb/internal/services/v0"
 	"github.com/authzed/spicedb/pkg/cmd/server"
 	"github.com/authzed/spicedb/pkg/cmd/termination"
+	"github.com/authzed/spicedb/pkg/runtime"
 )
 
 func RegisterDevtoolsFlags(cmd *cobra.Command) {
@@ -42,6 +44,11 @@ func RegisterDevtoolsFlags(cmd *cobra.Command) {
 	cmd.Flags().String("s3-bucket", "", "s3 bucket name for s3 share store")
 	cmd.Flags().String("s3-endpoint", "", "s3 endpoint for s3 share store")
 	cmd.Flags().String("s3-region", "auto", "s3 region for s3 share store")
+
+	otel := cobraotel.New(cmd.Use)
+	otel.RegisterFlags(cmd.Flags())
+	termination.RegisterFlags(cmd.Flags())
+	runtime.RegisterFlags(cmd.Flags())
 }
 
 func NewDevtoolsCommand(programName string) *cobra.Command {