docs: update creating vehicle and sensor model pages

[ismetatabay]

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[github-actions]

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-460/
Modified URLs:

• https://autowarefoundation.github.io/autoware-documentation/pr-460/contributing/coding-guidelines/ros-nodes/coordinate-system/
• https://autowarefoundation.github.io/autoware-documentation/pr-460/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-description/creating-vehicle-and-sensor-description/
• https://autowarefoundation.github.io/autoware-documentation/pr-460/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/calibrating-sensors/
• https://autowarefoundation.github.io/autoware-documentation/pr-460/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-individual-params/
• https://autowarefoundation.github.io/autoware-documentation/pr-460/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-sensor-model/
• https://autowarefoundation.github.io/autoware-documentation/pr-460/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/creating-vehicle-model/
• https://autowarefoundation.github.io/autoware-documentation/pr-460/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/
• https://autowarefoundation.github.io/autoware-documentation/pr-460/how-to-guides/integrating-autoware/creating-your-autoware-repositories/creating-autoware-repositories/

[ismetatabay]

@mitsudome-r Hi Mitsudome-san, this PR is ready for review. (FYI)

[danielsanchezaran]

@ismetatabay I am yet to review the "Creating a vehicle model for Autoware" section, will do that on Monday probably. I have left several reviews and suggestions that I believe will slightly improve the readability of the guide. Overall I believe this PR offers a considerable improvement on the original guide and I thank you for your effort.

One comment I would like to make is that your updated guide still uses the YOUR_VEHICLE_NAME convention along with the "tutorial_vehicle" convention. I believe that, while the guide can still be understood pretty well, it is better to only use the "tutorial_vehicle" part and rewrite the examples that use YOUR_VEHICLE_NAME. But that is my point of view. Maybe @mitsudome-r can weight in on that?

[ismetatabay]

@danielsanchezaran, Thank you very much for your review comments as well. I completely agree with these changes, and I have implemented all of your suggestions.

I wanted to illustrate generalization using YOUR_VEHICLE_NAME for new users, and I used tutorial_vehicle as an example in this context. If it becomes confusing for newcomers, we can discuss whether to remove YOUR_VEHICLE_NAME or tutorial_vehicle. However, I believe it's beneficial to retain both, as tutorial_vehicle features different sensor configurations.

FYI: @mitsudome-r

[danielsanchezaran]

Some suggestions for the "creating a vehicle model" section.

[danielsanchezaran]

@danielsanchezaran, Thank you very much for your review comments as well. I completely agree with these changes, and I have implemented all of your suggestions.

I wanted to illustrate generalization using YOUR_VEHICLE_NAME for new users, and I used tutorial_vehicle as an example in this context. If it becomes confusing for newcomers, we can discuss whether to remove YOUR_VEHICLE_NAME or tutorial_vehicle. However, I believe it's beneficial to retain both, as tutorial_vehicle features different sensor configurations.

FYI: @mitsudome-r

Hmm I see your point. After reading the "Creating a vehicle model for Autoware" part of your updated guide, I agree, I think it is good to have both, YOUR_VEHICLE_NAME and also tutorial_vehicle, as long a s the distinction is clear.

[ismetatabay]

@danielsanchezaran I updated the documentation with your suggestions. These suggestions really enhance the readability of the documentation. Thank you for your effort. 💯

[ismetatabay]

@danielsanchezaran, @mitsudome-r Hi, is it okay to merge?

[mitsudome-r]

@danielsanchezaran Thanks for the review.
@ismetatabay It seems like there are conflicts. We can merge this once they are fixed.