feat(json-schema-check): allow for several schema files per package #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambroise-arm
changed the title
Merged
7 tasks
3 tasks
Signed-off-by: Ambroise Vincent <[email protected]>
The goal is to allow one schema file per node in a package. And to allow several configuration files per schema. The schema files have to follow a NODE_NAME.schema.json naming convention and the configuration files have to follow a NODE_NAME*.param.yaml naming convention. Signed-off-by: Ambroise Vincent <[email protected]>
ambroise-arm
force-pushed
the
several-schema-per-package
branch
from
a807eda to
8cf3e09
Compare
isamu-takagi
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal is to allow one schema file per node in a package. And to allow several configuration files per schema. The schema files have to follow a NODE_NAME.schema.json naming convention and the configuration files have to follow a NODE_NAME*.param.yaml naming convention.
Related links
Implements #232 (comment)
Depends on autowarefoundation/autoware.universe#5798 in order to pass on the autoware.universe codebase
Tests performed
Command run locally on autoware.universe with the changes in the PR above.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.