refactor(json-schema): align schema and config file names

[ambroise-arm]

Description

The current paths of the schema/config files need to be changed slightly to account for a limitation in the current design where a package can't have more than one schema file (otherwise the CI fails). The update to the design is described in autowarefoundation/autoware-github-actions#232 (comment)

The schema files need to follow a NODE_NAME.schema.json naming convention and the configuration files need to follow a NODE_NAME*.param.yaml naming convention. It allows to have one schema file per node in a package.

Rename files that didn't match this pattern.

Related links

Align the autoware.universe codebase with #5289

After this PR is merged, autowarefoundation/autoware-github-actions#263 can be moved out of draft

This will probably unblock #4902

Tests performed

Verified the configurations files renamed were not referred to in other autoware.universe packages.

Only CI tests were run

Notes for reviewers

Interface changes

Changed the paths of some .schema.json and .param.yaml files.

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[isamu-takagi]

@ambroise-arm Different nodes may be created with partially matching names (e.g. my_node and my_node_tool). In this case, my_node.schema.json will check both my_node.param.yaml and my_node_tool.param.yaml.

So, I suggest using a slash that cannot be used in nodes as a separator. In other words, create a directory with the node name like below.

• schema/my_node.schema.json
• schema/my_node_tool.schema.json
• config/my_node/setting1.param.yaml
• config/my_node/setting2.param.yaml
• config/my_node_tool/default.param.yaml

[ambroise-arm]

Ah yes, indeed. I agree that it will not work if nodes have names that partially match. And your suggestion looks good to me. However, it would imply a change touching every single package in autoware.universe. I suppose it would need to be discussed and agreed first. I am not planning to do that in this PR.

I think the change I introduce here is strictly better than the current design, as it would allow to unblock #4902 while introducing no regression to the packages that have already implemented a schema file.

[isamu-takagi]

@ambroise-arm OK. We will discuss the issue of partially matching names separately.

[isamu-takagi]

LGTM (mission_planner package)

[ambroise-arm]

@miursh @scepter914 Please review when you have time

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4016c05) 15.25% compared to head (1bbb4f5) 15.25%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5798   +/-   ##
=======================================
  Coverage   15.25%   15.25%           
=======================================
  Files        1750     1750           
  Lines      120562   120562           
  Branches    36735    36735           
=======================================
  Hits        18390    18390           
  Misses      81543    81543           
  Partials    20629    20629           

Flag	Coverage Δ		*Carryforward flag
differential	18.38% <ø> (?)
total	15.25% <ø> (ø)		Carriedforward from 4016c05

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[scepter914]

LGTM (radar_object_fusion_to_detected_object)