-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoware_interpolation from autoware.universe #149
feat: port autoware_interpolation from autoware.universe #149
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it’s a porting task, I’m keeping the review to a minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
The error with |
Signed-off-by: jack.song <[email protected]> Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Co-authored-by: Yutaka Kondo <[email protected]> Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Hi, @youtalk, this PR is ready to be merged now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it’s a porting PR, please just fix these small adjustments.
common/autoware_interpolation/include/autoware/interpolation/spline_interpolation.hpp
Outdated
Show resolved
Hide resolved
common/autoware_interpolation/test/src/test_spline_interpolation.cpp
Outdated
Show resolved
Hide resolved
common/autoware_interpolation/test/src/test_spline_interpolation_points_2d.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Yutaka Kondo <[email protected]>
…pline_interpolation.hpp Co-authored-by: Yutaka Kondo <[email protected]>
…on.cpp Co-authored-by: Yutaka Kondo <[email protected]>
…on_points_2d.cpp Co-authored-by: Yutaka Kondo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi mits san @mitsudome-r Best regards 心刚 |
@liuXinGangChina It needs to be merged simultaneously with the PR that removes |
Package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NorahXiong @youtalk @shulanbushangshu.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since the blocker PR was merged last week. I'm testing the build again. |
I have tested build with this PR and the one in Autoware.Universe, but it seems like there are a lot of packages that depends on autoware_universe_utils through this package and got a lot of errors during build. It's better to remove the dependency to autoware_universe_utils with autoware_utils in Autoware.Universe first to make sure that the build passes, and then do the porting. I am creating the following PRs to fix this issue:
|
Description
Port autoware_interpolation from Autoware.Universe
Related links
#139
Parent Issue:
How was this PR tested?
Notes for reviewers
Should be handled after these changes be merged:
#23
Interface changes
None.
Effects on system behavior
None.