-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ndt_scan_matcher & timing_violation_monitor): add function to notify end of Path to timing_violation_monitor
#2638
Conversation
@nabetetsu |
system/tier4_timing_violation_monitor/tier4_timing_violation_monitor_utils/LICENSE
Outdated
Show resolved
Hide resolved
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
31b2cdc
to
93d591d
Compare
...ng_violation_monitor/include/timing_violation_monitor_utils/message_consumption_notifier.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I would like to have some discussion within TIER IV about the architecture of timing_violation_monitor. Please wait for a while before merging until the discussion is over. |
…ory) Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…tation Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
…sts.txt Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Co-authored-by: Takayuki AKAMINE <[email protected]>
…e localization changes from PR Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
Signed-off-by: Tetsuo Watanabe <[email protected]>
In order to separate the localization fixes and timing_violaton_monitor fixes, close this PR and create a new PR clipping only the localization fixes reviewed in this PR. |
Description
I'd like to add a new timing violation monitoring feature to the
Localization
of Autoware.universe. Timing violation means the event when response time is larger than expected.For more information on
timing_violation_moinitor
, please see the Discussion thread.As mentioned in the Discussion thread above, the timestamp value contained in topic is important for monitoring response time with
timing_violation_monitor
. As explained in the "Precondition on timestamp" section of the Discussion thread, if the end of the path is publishing an existing topic, thentiming_violation_monitor
will receive that topic nad use timestamp included in the topic. By using an existing topic, there is no implementation changes to the existing node implementation.On the other hand, if the timestamp passed from the start node is not output at the end of node, it is necessary to send a dedicated message.
In this PR,
system/timing_violation_monitor
library is added to provide a function to send a dedicated message, which will be used inndt_scan_matcher
.This PR focuses on the impact on existing code that may be caused by the introduction of the
system/timing_violation_monitor
mechanism. Therefore, this PR does not include the core implementation oftiming_violation_monitor
node. Since subscriber does not exist at this moment, so it has no operational impact.The dedicated message is added in
tier4_autoware_msgs
by this PR.I will create another PR for
timing_violation_monitor
node implementation.The following overview diagram of the operation of timing_violation_monitor shows the areas of focus in this PR.
Changes
ssytem/timing_violation_monitor
as libarary forLocalization
system/timing_violation_monitor
ndt_scan_matcher/ndt_scan_matcher_core.cpp
Related links
Discussion thread
Tests performed
There is no operational impact from this PR at all.
The PR of the
timing_violation_monitor node
itself presents the test results.Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.