-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockage_diag): dust detection #3212
Conversation
Signed-off-by: Yusuke Mizoguchi <[email protected]>
Sorry i could not understand. Where is the dust located on the lidar in your demo? Would your algorithm also work with other things, such as water drops, snow, bird 🐦💩? |
@VRichardJP
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: badai-nguyen <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
==========================================
- Coverage 15.02% 14.96% -0.07%
==========================================
Files 1609 1614 +5
Lines 111684 112143 +459
Branches 34605 34601 -4
==========================================
- Hits 16784 16783 -1
- Misses 76201 76663 +462
+ Partials 18699 18697 -2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I have reproduced the result using logging_simulator as below: |
sensing/pointcloud_preprocessor/src/blockage_diag/blockage_diag_nodelet.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
sensing/pointcloud_preprocessor/src/blockage_diag/blockage_diag_nodelet.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: badai-nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your support.
* implement about dust detection Signed-off-by: Yusuke Mizoguchi <[email protected]> * chore: fix spell Signed-off-by: badai-nguyen <[email protected]> * chore: refactor Signed-off-by: badai-nguyen <[email protected]> * bug fix Signed-off-by: Shunsuke Miura <[email protected]> * fix: avoid counter overflow Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: Yusuke Mizoguchi <[email protected]> Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: badai nguyen <[email protected]> Co-authored-by: badai-nguyen <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]>
Description
I implemented dust detection process.
When dust covers the lidar, noise is added to the depth image. Therefore, I thought that noise(dust area) can be detected by applying noise reduction algorithms.
So,I implemented an algorithm used for noise reduction, morphological processing.
Here are the results of my implementation.
This is a video of rosbag with dust(only front_upper) on the lidar.
The second image from the top is a depth image, showing noise in the area where the dust is attached.
The top image is the output image when the process is executed.
The red color indicates the result of detecting blockage area, which has been implemented previously.
The yellow color indicates the result of detecting dusty area, which is result of my new implementation.
Related links
tier4 INTERNAL LINK : about this dust detection
Related PR
feat: add params and diag about dust-detection by swiftfile · Pull Request #116 · tier4/aip_launcher
feat(blockage_diag): dust detection by swiftfile · Pull Request #3192 · autowarefoundation/autoware.universe (cancelled PR)
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.