-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add params and diag about dust-detection #116
Merged
badai-nguyen
merged 8 commits into
tier4:tier4/universe
from
swiftfile:sensing/t4-wholedust-dev
Sep 28, 2023
Merged
feat: add params and diag about dust-detection #116
badai-nguyen
merged 8 commits into
tier4:tier4/universe
from
swiftfile:sensing/t4-wholedust-dev
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o sensing/t4-wholedust-dev # Conflicts: # aip_x2_launch/launch/pandar_node_container.launch.py
7 tasks
swiftfile
changed the title
add params and diag about dust-blockage
add params and diag about dust-detection
Mar 28, 2023
7 tasks
swiftfile
changed the title
add params and diag about dust-detection
feat: add params and diag about dust-detection
Mar 29, 2023
badai-nguyen
previously approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: badai-nguyen <[email protected]>
badai-nguyen
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds diagnostics and launch parameters in order to implement dust detection by lidar(new feature).
Related PR
feat(blockage_diag): dust detection by swiftfile · Pull Request #3212 · autowarefoundation/autoware.universe