Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add params and diag about dust-detection #116

Merged
merged 8 commits into from
Sep 28, 2023

Conversation

swiftfile
Copy link
Contributor

@swiftfile swiftfile commented Mar 28, 2023

Description

This PR adds diagnostics and launch parameters in order to implement dust detection by lidar(new feature).

Related PR

feat(blockage_diag): dust detection by swiftfile · Pull Request #3212 · autowarefoundation/autoware.universe

@swiftfile swiftfile changed the title add params and diag about dust-blockage add params and diag about dust-detection Mar 28, 2023
@swiftfile swiftfile marked this pull request as ready for review March 29, 2023 10:16
@swiftfile swiftfile marked this pull request as draft March 29, 2023 10:22
@swiftfile swiftfile marked this pull request as ready for review March 29, 2023 10:23
@swiftfile swiftfile changed the title add params and diag about dust-detection feat: add params and diag about dust-detection Mar 29, 2023
@badai-nguyen badai-nguyen self-requested a review March 30, 2023 09:54
@badai-nguyen badai-nguyen requested a review from miursh September 22, 2023 05:15
badai-nguyen
badai-nguyen previously approved these changes Sep 22, 2023
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen merged commit a4f6d59 into tier4:tier4/universe Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants