-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goal_planner): do not use minimum_request_length for fixed goal planner #4831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
c267a1a
to
bd75ea4
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4831 +/- ##
=======================================
Coverage 15.17% 15.17%
=======================================
Files 1578 1578
Lines 108584 108564 -20
Branches 33374 33372 -2
=======================================
- Hits 16475 16472 -3
+ Misses 74193 74177 -16
+ Partials 17916 17915 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…planner Signed-off-by: kosuke55 <[email protected]>
bd75ea4
to
28efc60
Compare
…planner (autowarefoundation#4831) Signed-off-by: kosuke55 <[email protected]>
…planner (autowarefoundation#4831) Signed-off-by: kosuke55 <[email protected]>
…planner (autowarefoundation#4831) Signed-off-by: kosuke55 <[email protected]>
Description
do not use minimum_request_length for fixed goal planner
need
of planner manager
Related links
autowarefoundation/autoware_launch#546
Tests performed
psim
https://evaluation.tier4.jp/evaluation/reports/3ae99ec3-73aa-56cd-bd1f-173fdbb2cd9a?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.