Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): do not use minimum_request_length for fixed goal planner #4831

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 31, 2023

Description

do not use minimum_request_length for fixed goal planner

need

  • keep last
  • always ececutable

of planner manager

Related links

autowarefoundation/autoware_launch#546

Tests performed

psim
https://evaluation.tier4.jp/evaluation/reports/3ae99ec3-73aa-56cd-bd1f-173fdbb2cd9a?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 marked this pull request as ready for review August 31, 2023 05:03
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 31, 2023
@kosuke55 kosuke55 requested a review from takayuki5168 as a code owner August 31, 2023 05:03
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 31, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@kosuke55 kosuke55 force-pushed the feat/fixed_goal_request branch 3 times, most recently from c267a1a to bd75ea4 Compare September 4, 2023 18:03
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (30ec8f7) 15.17% compared to head (bd75ea4) 15.17%.
Report is 5 commits behind head on main.

❗ Current head bd75ea4 differs from pull request most recent head 28efc60. Consider uploading reports for the commit 28efc60 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4831   +/-   ##
=======================================
  Coverage   15.17%   15.17%           
=======================================
  Files        1578     1578           
  Lines      108584   108564   -20     
  Branches    33374    33372    -2     
=======================================
- Hits        16475    16472    -3     
+ Misses      74193    74177   -16     
+ Partials    17916    17915    -1     
Flag Coverage Δ *Carryforward flag
differential 13.06% <0.00%> (?)
total 15.17% <ø> (+<0.01%) ⬆️ Carriedforward from e68e8ac

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.cpp 5.94% <0.00%> (+0.02%) ⬆️
..._planner/src/scene_module/goal_planner/manager.cpp 8.86% <0.00%> (-0.06%) ⬇️

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the feat/fixed_goal_request branch from bd75ea4 to 28efc60 Compare September 5, 2023 13:38
@kosuke55 kosuke55 merged commit c442e38 into main Sep 5, 2023
@kosuke55 kosuke55 deleted the feat/fixed_goal_request branch September 5, 2023 17:21
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 6, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 6, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants