Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): always run fixed_goal_planner #804

Closed
wants to merge 2 commits into from

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Sep 6, 2023

Description

[X2][beta/v2.2.1] goal poseが固定してリサンプルされていない(操舵ガタつきに影響)
https://tier4.atlassian.net/browse/RT0-28869
の修正

before

image

after

image

※ あとからstart_planner, LCが来てしまう場合は経路が上書きされてしまい、このパターンのみ未対応です。
(autowarefoundation#4811 をcherry-pickすれば治りますが、コンフリクト解消がやや面倒)

image

Related links

Tests performed

psim

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kosuke55 and others added 2 commits September 6, 2023 17:50
…owarefoundation#4785)

* feat(behavior_path_planner): add always executable module option

Signed-off-by: kosuke55 <[email protected]>

* fix conditions

Signed-off-by: kosuke55 <[email protected]>

* rename itr

Signed-off-by: kosuke55 <[email protected]>

* Update planning/behavior_path_planner/src/planner_manager.cpp

Co-authored-by: Satoshi OTA <[email protected]>

* Update planning/behavior_path_planner/src/planner_manager.cpp

Co-authored-by: Satoshi OTA <[email protected]>

* Update planning/behavior_path_planner/src/planner_manager.cpp

Co-authored-by: Satoshi OTA <[email protected]>

* fix candidate break

Signed-off-by: kosuke55 <[email protected]>

* Revert "fix candidate break"

This reverts commit 0071bbd.

* remove continue

Signed-off-by: kosuke55 <[email protected]>

* check manager_ptr->isAlwaysExecutableModule first

Signed-off-by: kosuke55 <[email protected]>

* common similar process

Signed-off-by: kosuke55 <[email protected]>

* fix getRequestModules

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
@github-actions github-actions bot added documentation Improvements or additions to documentation planning labels Sep 6, 2023
@kosuke55 kosuke55 changed the title Fix/fixed goal v0.9.1 feat(goal_planner): always run fixed_goal_planner Sep 6, 2023
@kosuke55 kosuke55 closed this Dec 2, 2023
@kosuke55 kosuke55 deleted the fix/fixed_goal_v0.9.1 branch June 26, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants