Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vehicle_cmd_gate)!: add steer and steer_rate filter #5044

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 20, 2023

Description

Add new filters:

  • steering angle limit filter
  • steering angle rate limit filter

Note: now there is a filter for lateral acceleration and lateral jerk, but since these values are related to both steering and velocity, it is a bit complicated to tune parameters sometimes. For the issue, I introduce a more simple filter for steering and steering rate limit.

Related links

TIERIV internal ticket

Tests performed

Run psim and make sure the vehicle can drive in a shape turn.
image

Notes for reviewers

None

Interface changes

New parameters are added. Must be merged with autowarefoundation/autoware_launch#576

Effects on system behavior

Steering angle and steering angle rate filter will be activated

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 20, 2023
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 37.17% and project coverage change: +0.01% 🎉

Comparison is base (909f12f) 15.71% compared to head (d0788bc) 15.73%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5044      +/-   ##
==========================================
+ Coverage   15.71%   15.73%   +0.01%     
==========================================
  Files        1579     1579              
  Lines      109342   109407      +65     
  Branches    34106    34147      +41     
==========================================
+ Hits        17188    17216      +28     
- Misses      73239    73240       +1     
- Partials    18915    18951      +36     
Flag Coverage Δ *Carryforward flag
differential 41.31% <37.17%> (?)
total 15.71% <ø> (+<0.01%) ⬆️ Carriedforward from 909f12f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp 25.00% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 24.47% <0.00%> (+<0.01%) ⬆️
.../test/src/test_filter_in_vehicle_cmd_gate_node.cpp 60.00% <0.00%> (-0.82%) ⬇️
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
...calizer/include/ekf_localizer/hyper_parameters.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)
...icle_cmd_gate/test/src/test_vehicle_cmd_filter.cpp 36.86% <33.33%> (-0.96%) ⬇️
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp 64.88% <51.85%> (-2.26%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit a84418a into autowarefoundation:main Sep 21, 2023
37 of 39 checks passed
@TakaHoribe TakaHoribe deleted the gate-steer-rate-filter branch September 21, 2023 05:13
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 16, 2023
…ndation#5044)

* feat(vehicle_cmd_gate): add steering angle and rate filter

Signed-off-by: Takamasa Horibe <[email protected]>

* update test

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants