-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vehicle_cmd_gate)!: add steer and steer_rate filter #5044
feat(vehicle_cmd_gate)!: add steer and steer_rate filter #5044
Conversation
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5044 +/- ##
==========================================
+ Coverage 15.71% 15.73% +0.01%
==========================================
Files 1579 1579
Lines 109342 109407 +65
Branches 34106 34147 +41
==========================================
+ Hits 17188 17216 +28
- Misses 73239 73240 +1
- Partials 18915 18951 +36
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ndation#5044) * feat(vehicle_cmd_gate): add steering angle and rate filter Signed-off-by: Takamasa Horibe <[email protected]> * update test Signed-off-by: Takamasa Horibe <[email protected]> --------- Signed-off-by: Takamasa Horibe <[email protected]>
Description
Add new filters:
Note: now there is a filter for lateral acceleration and lateral jerk, but since these values are related to both steering and velocity, it is a bit complicated to tune parameters sometimes. For the issue, I introduce a more simple filter for steering and steering rate limit.
Related links
TIERIV internal ticket
Tests performed
Run psim and make sure the vehicle can drive in a shape turn.
Notes for reviewers
None
Interface changes
New parameters are added. Must be merged with autowarefoundation/autoware_launch#576
Effects on system behavior
Steering angle and steering angle rate filter will be activated
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.