Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rtc_auto_mode_manager): rework parameters #5190

Conversation

PhoebeWu21
Copy link
Member

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the rtc_auto_mode_manager package.

  • Create the schema

Tests performed

Package built locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to rtc_auto_mode_manager

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 2, 2023
@rej55
Copy link
Contributor

rej55 commented Oct 2, 2023

@PhoebeWu21 Thank you for your contribution!
rtc_auto_mode_manager will be eliminated, so this change may be unnecessary.
#5182

If this is not urgent, we can close this PR.
How do you think?

@PhoebeWu21
Copy link
Member Author

PhoebeWu21 commented Oct 2, 2023

@PhoebeWu21 Thank you for your contribution! rtc_auto_mode_manager will be eliminated, so this change may be unnecessary. #5182

If this is not urgent, we can close this PR. How do you think?

@rej55 Oh! Okay, thank you for the reminding.

@PhoebeWu21 PhoebeWu21 closed this Oct 2, 2023
@PhoebeWu21 PhoebeWu21 deleted the refactor-node-config-rtc_auto_mode_manager branch October 3, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants