fix(simulator, controller): fix inverse pitch calculation

[soblin]

Description

Related links

launcher PR: autowarefoundation/autoware_launch#613

Tests performed

Before this PR

PR5199-2023-10-03_09.48.36.mp4

After this PR

PR5199-2023-10-03_09.45.07.mp4

Notes for reviewers

Interface changes

none.

Effects on system behavior

ego's pitch angle will align with the map slope.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[TakaHoribe]

@brkay54 This is a very simple fix for the wrong pitch sign in the simulator reported by you. This may cause a conflict with your PRs, but can we merge this PR?

[brkay54]

@brkay54 This is a very simple fix for the wrong pitch sign in the simulator reported by you. This may cause a conflict with your PRs, but can we merge this PR?

It is better to merge this one before the mine PRs about PID controller. Already I need to make some changes with respect to your review, while doing this I can also solve the conflicts. Thank you @TakaHoribe -san !

[brkay54]

@TakaHoribe @soblin If everything is okay, can we enable auto-merge?

[soblin]

I will make a minor change to the added figure then merge this PR

[soblin]

I attached before/after video in the description

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (93b6118) 14.77% compared to head (14db08d) 14.78%.
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5199   +/-   ##
=======================================
  Coverage   14.77%   14.78%           
=======================================
  Files        1636     1636           
  Lines      113635   113633    -2     
  Branches    34932    34932           
=======================================
+ Hits        16793    16795    +2     
+ Misses      78001    77998    -3     
+ Partials    18841    18840    -1     

Flag	Coverage Δ		*Carryforward flag
differential	47.17% <50.00%> (?)
total	14.77% <ø> (-0.01%)	⬇️	Carriedforward from cfe2cdc

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...nal_controller/src/pid_longitudinal_controller.cpp	38.72% <100.00%> (ø)
...em_monitor/src/process_monitor/process_monitor.cpp	0.00% <ø> (ø)
...nning_simulator/simple_planning_simulator_core.cpp	37.81% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.