-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): yield initially on green light #5234
feat(intersection): yield initially on green light #5234
Conversation
3a90c44
to
aa7ce09
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
aa7ce09
to
24dc7d1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5234 +/- ##
==========================================
- Coverage 14.78% 14.74% -0.04%
==========================================
Files 1648 1648
Lines 113979 114459 +480
Branches 35108 35450 +342
==========================================
+ Hits 16848 16878 +30
- Misses 78193 78596 +403
- Partials 18938 18985 +47
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <[email protected]>
It seems that the ego vehicle stops in vain if the corresponding allow signal is green. |
Signed-off-by: Mamoru Sobue <[email protected]>
…n#5234) Signed-off-by: Mamoru Sobue <[email protected]>
…n#5234) Signed-off-by: Mamoru Sobue <[email protected]>
…n#5234) Signed-off-by: Mamoru Sobue <[email protected]>
Description
When ego vehicle entered the intersection on green traffic light collision is not detected instantly because NPC vehicles are very slow. This PR adds the feature to detect whatever vehicles in the attention area and stop for a while.
Related links
https://tier4.atlassian.net/browse/RT0-29284
launcher PR: autowarefoundation/autoware_launch#623
Tests performed
In the attached video [00:07], "intersection" stop line is inserted even if the ego/NPCs are very slow.
PR5234-2023-10-06_22.06.25.mp4
evaluator: https://evaluation.tier4.jp/evaluation/reports/ec7990b5-f3b7-549c-822d-22c3f72201f1?project_id=prd_jt
Notes for reviewers
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.