Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): yield initially on green light #5234

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 5, 2023

Description

When ego vehicle entered the intersection on green traffic light collision is not detected instantly because NPC vehicles are very slow. This PR adds the feature to detect whatever vehicles in the attention area and stop for a while.

Related links

https://tier4.atlassian.net/browse/RT0-29284
launcher PR: autowarefoundation/autoware_launch#623

Tests performed

In the attached video [00:07], "intersection" stop line is inserted even if the ego/NPCs are very slow.

PR5234-2023-10-06_22.06.25.mp4

evaluator: https://evaluation.tier4.jp/evaluation/reports/ec7990b5-f3b7-549c-822d-22c3f72201f1?project_id=prd_jt

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 5, 2023
@soblin soblin force-pushed the feat/intersection/pseudo-collision-on-green-light branch 2 times, most recently from 3a90c44 to aa7ce09 Compare October 6, 2023 00:09
@soblin soblin marked this pull request as ready for review October 6, 2023 00:22
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 6, 2023
@kyoichi-sugahara kyoichi-sugahara self-assigned this Oct 6, 2023
@soblin soblin force-pushed the feat/intersection/pseudo-collision-on-green-light branch from aa7ce09 to 24dc7d1 Compare October 6, 2023 01:02
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (877b04b) 14.78% compared to head (392d5b6) 14.74%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5234      +/-   ##
==========================================
- Coverage   14.78%   14.74%   -0.04%     
==========================================
  Files        1648     1648              
  Lines      113979   114459     +480     
  Branches    35108    35450     +342     
==========================================
+ Hits        16848    16878      +30     
- Misses      78193    78596     +403     
- Partials    18938    18985      +47     
Flag Coverage Δ *Carryforward flag
differential 6.29% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from 4b506a8

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <ø> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...avior_velocity_intersection_module/src/manager.cpp 21.42% <0.00%> (+5.11%) ⬆️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55
Copy link
Contributor

rej55 commented Oct 6, 2023

It seems that the ego vehicle stops in vain if the corresponding allow signal is green.

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin merged commit 0c48944 into autowarefoundation:main Oct 6, 2023
20 of 24 checks passed
@soblin soblin deleted the feat/intersection/pseudo-collision-on-green-light branch October 6, 2023 16:27
@soblin soblin restored the feat/intersection/pseudo-collision-on-green-light branch October 6, 2023 16:27
@soblin soblin deleted the feat/intersection/pseudo-collision-on-green-light branch October 6, 2023 16:27
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants