-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rtc_auto_mode_manager): eliminate rtc auto mode manager #5235
Merged
kyoichi-sugahara
merged 9 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/eliminate_RTC_auto_mode_manager
Oct 7, 2023
Merged
feat(rtc_auto_mode_manager): eliminate rtc auto mode manager #5235
kyoichi-sugahara
merged 9 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/eliminate_RTC_auto_mode_manager
Oct 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Oct 5, 2023
Merged
5 tasks
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Oct 5, 2023
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
rej55,
taikitanaka3,
satoshi-ota,
shmpwk,
tkimura4,
kosuke55,
soblin,
takayuki5168,
TakaHoribe,
purewater0901,
zulfaqar-azmi-t4,
mkuri and
TomohitoAndo
as code owners
October 6, 2023 04:28
Signed-off-by: kyoichi-sugahara <[email protected]>
rej55
approved these changes
Oct 6, 2023
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
rej55
approved these changes
Oct 6, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5235 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1648 1648
Lines 113977 113977
Branches 35122 35122
=======================================
+ Hits 16850 16852 +2
+ Misses 78184 78183 -1
+ Partials 18943 18942 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
approved these changes
Oct 6, 2023
takayuki5168
approved these changes
Oct 6, 2023
taikitanaka3
approved these changes
Oct 6, 2023
TakaHoribe
approved these changes
Oct 7, 2023
tkimura4
approved these changes
Oct 7, 2023
kyoichi-sugahara
merged commit Oct 7, 2023
83821d4
into
autowarefoundation:main
23 of 24 checks passed
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should be merged first.
TODO
rtc_replayer
worksRelated links
#5182
Tests performed
confirmed with planning simulator
enable_RTC: false
for start_planner and approve is unnecessaryenable_RTC: true
for start_planner and approve is necessaryswitch between auto_mode and manual_mode
Screencast from 2023年10月06日 13時05分51秒.webm
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.