Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_auto_mode_manager): eliminate rtc auto mode manager #5235

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Oct 5, 2023

Description

This PR should be merged first.

TODO

  • confirm rtc_replayer works

Related links

#5182

Tests performed

confirmed with planning simulator

  • control initial state auto_mode or manual_mode from parameter

enable_RTC: false for start_planner and approve is unnecessary
Screenshot from 2023-10-06 13-27-20

enable_RTC: true for start_planner and approve is necessary
image

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Oct 5, 2023
@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 5, 2023
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (950805f) 14.78% compared to head (69df2e3) 14.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5235   +/-   ##
=======================================
  Coverage   14.78%   14.78%           
=======================================
  Files        1648     1648           
  Lines      113977   113977           
  Branches    35122    35122           
=======================================
+ Hits        16850    16852    +2     
+ Misses      78184    78183    -1     
+ Partials    18943    18942    -1     
Flag Coverage Δ *Carryforward flag
differential 11.47% <ø> (?)
total 14.78% <ø> (ø) Carriedforward from 950805f

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 83821d4 into autowarefoundation:main Oct 7, 2023
23 of 24 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/eliminate_RTC_auto_mode_manager branch October 7, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants