Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(motion_velocity_smoother): align processing time topic name #5273

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 11, 2023

Description

🤖 Generated by Copilot at 0f724cc

Refactored the motion velocity smoother node to improve performance and readability. Renamed the topic for publishing the processing time to ~/debug/processing_time_ms.

Tests performed

➜  pilot-auto git:(awf-latest) ✗ ros2 topic echo /planning/scenario_planning/motion_velocity_smoother/debug/processing_time_ms                                                                                                                                                                                                                                                                                                  
stamp:                                                                                                                                                                                                                                                                                                                                                                                                                          
  sec: 1697073393                                                                                                                                                                                                                                                                                                                                                                                                               
  nanosec: 735140327                                                                                    
data: 12.781999588012695                                                                                
---                                                                                                     
stamp:                                                                                                  
  sec: 1697073393                                                                                       
  nanosec: 882572164                                                                                    
data: 10.720999717712402                                                                                
---                                                                                                     
stamp:                                                                                                  
  sec: 1697073393                                                                                       
  nanosec: 931832309                                                                                    
data: 9.756999969482422                

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 11, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 12, 2023
@satoshi-ota satoshi-ota enabled auto-merge (squash) October 12, 2023 01:17
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dc8cc07) 14.84% compared to head (0f724cc) 14.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5273      +/-   ##
==========================================
- Coverage   14.84%   14.82%   -0.02%     
==========================================
  Files        1649     1649              
  Lines      114166   114289     +123     
  Branches    35322    35420      +98     
==========================================
  Hits        16943    16943              
- Misses      78102    78216     +114     
- Partials    19121    19130       +9     
Flag Coverage Δ *Carryforward flag
differential 11.32% <0.00%> (?)
total 14.84% <ø> (+<0.01%) ⬆️ Carriedforward from dc8cc07

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 28.23% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 6b58314 into autowarefoundation:main Oct 12, 2023
43 of 45 checks passed
@satoshi-ota satoshi-ota deleted the refactor/align-namespace branch October 12, 2023 02:34
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants