fix(lane_change): add visualization for passParkedObject #5291
This check has been archived and is scheduled for deletion.
Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Oct 12, 2023 in 56s
CodeScene PR Check
✅ Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Details
✅ Positive Code Health Impact (highest to lowest):
- Primitive Obsession utils.cpp 🔥
Annotations
Check notice on line 1 in planning/behavior_path_planner/src/utils/lane_change/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 33.59% to 33.33%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 982 in planning/behavior_path_planner/src/utils/lane_change/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Excess Number of Function Arguments
passParkedObject increases from 6 to 7 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Loading