feat(duplicated_node_checker): add duplicated node names to msg #5382
Conversation
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
github-actions
bot
added
the
component:system
|
@Owen-Liuyuxuan @shmpwk |
| @@ -40,6 +40,7 @@ | |||
| /autoware/system/service_log_checker: { sf_at: "warn", lf_at: "none", spf_at: "none" } | |||
| /autoware/system/duplicated_node_checker: default | |||
| # /autoware/system/resource_monitoring: { sf_at: "warn", lf_at: "error", spf_at: "none" } | |||
| # /autoware/system/duplicated_node_checker: default | |||
There was a problem hiding this comment.
Could I know what is the motivation for adding this commented line in this file?
There was a problem hiding this comment.
It's to make it consistent with the config file on the launcher side, but the change is not necessary.
file:
https://github.com/autowarefoundation/autoware_launch/blob/13b28551b50141bd887042063e00cfc987c19e76/autoware_launch/config/system/system_error_monitor/system_error_monitor.planning_simulation.param.yaml#L42
FYI:
changed by following PR:
autowarefoundation/autoware_launch#649
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5382 +/- ##
==========================================
- Coverage 14.76% 14.76% -0.01%
==========================================
Files 1662 1662
Lines 115453 115455 +2
Branches 35640 35638 -2
==========================================
Hits 17045 17045
- Misses 79178 79180 +2
Partials 19230 19230
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
merged commit 69813cb
into
autowarefoundation:main
…warefoundation#5382) * add duplicated node names to msg Signed-off-by: kyoichi-sugahara <[email protected]> * align with launcher repository Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Description
🤖 Generated by Copilot at 232b433
This pull request enhances the
duplicated_node_checkernode to optionally report the names of duplicated nodes in the diagnostic message. It also updates the configuration files and comments for the node and its usage in thesystem_error_monitornode.add flag to show duplicated node names to msg (default false)
the motivation for this is it's necessary to check duplicated node name in the log file sometimes (e.g. running scenario simulator in CI/CD environment)
launcher PR should be merged first
Tests performed
Run scenario_simulator_v2 in local environment.
I confirmed node name is added to msg when duplicated node is launched shown below.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.