Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): fill all path point velocity to 0 when approached stopline #5428

Closed

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 27, 2023

Description

When ego approached collision stop line, insert zero velocity to all path points.

launcher PR: autowarefoundation/autoware_launch#660

Related links

Tests performed

before this PR

behind velocity is positive
image

after this PR

all velocity is zero
image

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 27, 2023
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (82a6c0c) 14.75% compared to head (e84d4fb) 14.75%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5428      +/-   ##
==========================================
- Coverage   14.75%   14.75%   -0.01%     
==========================================
  Files        1661     1661              
  Lines      115525   115533       +8     
  Branches    35670    35675       +5     
==========================================
  Hits        17050    17050              
- Misses      79231    79237       +6     
- Partials    19244    19246       +2     
Flag Coverage Δ *Carryforward flag
differential 5.61% <0.00%> (?)
total 14.75% <ø> (+<0.01%) ⬆️ Carriedforward from 82a6c0c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...avior_velocity_intersection_module/src/manager.cpp 14.07% <0.00%> (-0.11%) ⬇️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin closed this Nov 7, 2023
@soblin soblin deleted the fix/intersection/force-stop branch August 21, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant