Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detection_by_tracker): add ignore option for each label #5473

fix: launch

892b422
Select commit
Loading
Failed to load commit list.
Merged

fix(detection_by_tracker): add ignore option for each label #5473

fix: launch
892b422
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 2, 2023 in 35s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 3 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method utils.cpp: TrackerIgnoreLabel::isIgnore

✅ Improving Code Health:

  • Overall Code Complexity detection_by_tracker_core.cpp
  • Complex Method detection_by_tracker_core.cpp: DetectionByTracker::divideUnderSegmentedObjects
  • Complex Method detection_by_tracker_core.cpp: DetectionByTracker::mergeOverSegmentedObjects

Annotations

Check notice on line 270 in perception/detection_by_tracker/src/detection_by_tracker_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

DetectionByTracker::divideUnderSegmentedObjects decreases in cyclomatic complexity from 15 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 406 in perception/detection_by_tracker/src/detection_by_tracker_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

DetectionByTracker::mergeOverSegmentedObjects decreases in cyclomatic complexity from 14 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in perception/detection_by_tracker/src/detection_by_tracker_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 5.08 to 4.92, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 29 in perception/detection_by_tracker/src/utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

TrackerIgnoreLabel::isIgnore has a cyclomatic complexity of 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.