Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(probabilistic_occupancy_grid_map): add synchronized ogm fusion node #5485

Merged

Merge remote-tracking branch 'myorigin/feat/rearrange_grid_map_fusion…

ef35a7e
Select commit
Loading
Failed to load commit list.
Merged

feat(probabilistic_occupancy_grid_map): add synchronized ogm fusion node #5485

Merge remote-tracking branch 'myorigin/feat/rearrange_grid_map_fusion…
ef35a7e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Mar 13, 2024 in 42s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 97% of the historic high-risk change sets. The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method pointcloud_based_occupancy_grid_map_node.cpp: PointcloudBasedOccupancyGridMapNode::onPointcloudWithObstacleAndRaw

Annotations

Check warning on line 143 in perception/probabilistic_occupancy_grid_map/src/pointcloud_based_occupancy_grid_map/pointcloud_based_occupancy_grid_map_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

PointcloudBasedOccupancyGridMapNode::onPointcloudWithObstacleAndRaw increases in cyclomatic complexity from 13 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.