Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image_projection_based_fusion): enable to show iou value in roi_cluster_fusion debug image #5541

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Nov 9, 2023

Description

This PR enables user to see max_iou value in debug image of roi_cluster_fusion.
This will be helpful in debugging.

🤖 Generated by Copilot at 73fe8a9

This pull request adds a feature to show the IoU score for each image ROI on the image for debugging the image projection based fusion algorithm. It modifies the fuseOnSingleImage function in node.cpp to pass the IoU data to the Debugger class, and adds a new variable max_iou_for_image_rois_ to debugger.hpp. It also updates the publishImage function in debugger.cpp to draw the IoU score on the image.

Tests performed

image

If you do not like background color omit commit fc57a64.
image

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 9, 2023
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (bff877c) 15.35% compared to head (fc57a64) 15.32%.
Report is 15 commits behind head on main.

❗ Current head fc57a64 differs from pull request most recent head 887eca8. Consider uploading reports for the commit 887eca8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5541      +/-   ##
==========================================
- Coverage   15.35%   15.32%   -0.04%     
==========================================
  Files        1697     1702       +5     
  Lines      117455   117714     +259     
  Branches    37748    37748              
==========================================
  Hits        18041    18041              
- Misses      78873    79132     +259     
  Partials    20541    20541              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.36% <ø> (+<0.01%) ⬆️ Carriedforward from bff877c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <0.00%> (ø)
...ion/image_projection_based_fusion/src/debugger.cpp 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 6e60821 into autowarefoundation:main Nov 13, 2023
17 of 19 checks passed
@YoshiRi YoshiRi deleted the feat/display_iou_in_debug_image branch November 13, 2023 11:33
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…cluster_fusion debug image (autowarefoundation#5541)

* enable to show debug iou value in roi_cluster_fusion

Signed-off-by: yoshiri <[email protected]>

* refactor iou draw settings

Signed-off-by: yoshiri <[email protected]>

* add backgroud color to iou

Signed-off-by: yoshiri <[email protected]>

* prevent object copying when debugger is not enabled

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
YoshiRi added a commit to YoshiRi/autoware.universe that referenced this pull request Nov 29, 2023
…cluster_fusion debug image (autowarefoundation#5541)

* enable to show debug iou value in roi_cluster_fusion

Signed-off-by: yoshiri <[email protected]>

* refactor iou draw settings

Signed-off-by: yoshiri <[email protected]>

* add backgroud color to iou

Signed-off-by: yoshiri <[email protected]>

* prevent object copying when debugger is not enabled

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 14, 2024
…cluster_fusion debug image (autowarefoundation#5541)

* enable to show debug iou value in roi_cluster_fusion

Signed-off-by: yoshiri <[email protected]>

* refactor iou draw settings

Signed-off-by: yoshiri <[email protected]>

* add backgroud color to iou

Signed-off-by: yoshiri <[email protected]>

* prevent object copying when debugger is not enabled

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants