-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image_projection_based_fusion): fix iou geometry function #5568
feat(image_projection_based_fusion): fix iou geometry function #5568
Conversation
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5568 +/- ##
==========================================
+ Coverage 15.32% 15.39% +0.06%
==========================================
Files 1721 1702 -19
Lines 118559 116117 -2442
Branches 37995 36825 -1170
==========================================
- Hits 18169 17872 -297
+ Misses 79657 77870 -1787
+ Partials 20733 20375 -358
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…arefoundation#5568) * enable to show debug iou value in roi_cluster_fusion Signed-off-by: yoshiri <[email protected]> * refactor iou draw settings Signed-off-by: yoshiri <[email protected]> * add backgroud color to iou Signed-off-by: yoshiri <[email protected]> * prevent object copying when debugger is not enabled Signed-off-by: yoshiri <[email protected]> * fix roi geometry functions Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…arefoundation#5568) * enable to show debug iou value in roi_cluster_fusion Signed-off-by: yoshiri <[email protected]> * refactor iou draw settings Signed-off-by: yoshiri <[email protected]> * add backgroud color to iou Signed-off-by: yoshiri <[email protected]> * prevent object copying when debugger is not enabled Signed-off-by: yoshiri <[email protected]> * fix roi geometry functions Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…arefoundation#5568) * enable to show debug iou value in roi_cluster_fusion Signed-off-by: yoshiri <[email protected]> * refactor iou draw settings Signed-off-by: yoshiri <[email protected]> * add backgroud color to iou Signed-off-by: yoshiri <[email protected]> * prevent object copying when debugger is not enabled Signed-off-by: yoshiri <[email protected]> * fix roi geometry functions Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
Description
This PR fixes unintended behavior in geometry function in roi_cluster_fusion.
This is confirmed in roi_cluster_fusion debug related with odaiba experiment.
🤖 Generated by Copilot at 66c556f
Improved the image projection based fusion node by refactoring the code, enhancing the debugging functionality, and fixing some bugs. Added a new
Debugger
class to manage debug objects and visualize the IOU score. Modified theis_inside
andfuseOnSingleImage
functions to use a better formula and error handling. Added a newsanitizeROI
function to avoid out-of-bound errors.Tests performed
Tested with odaiba data.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.