Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image_projection_based_fusion): fix iou geometry function #5568

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Nov 13, 2023

Description

This PR fixes unintended behavior in geometry function in roi_cluster_fusion.
This is confirmed in roi_cluster_fusion debug related with odaiba experiment.

image

🤖 Generated by Copilot at 66c556f

Improved the image projection based fusion node by refactoring the code, enhancing the debugging functionality, and fixing some bugs. Added a new Debugger class to manage debug objects and visualize the IOU score. Modified the is_inside and fuseOnSingleImage functions to use a better formula and error handling. Added a new sanitizeROI function to avoid out-of-bound errors.

Tests performed

Tested with odaiba data.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 13, 2023
@YoshiRi YoshiRi changed the title feat(roi_cluster_fusion): fix iou geometry function feat(image_projection_based_fusion): fix iou geometry function Nov 13, 2023
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (092295a) 15.39%.
Report is 35 commits behind head on main.

Files Patch % Lines
...age_projection_based_fusion/src/utils/geometry.cpp 0.00% 22 Missing ⚠️
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% 7 Missing ⚠️
...usion/src/pointpainting_fusion/voxel_generator.cpp 0.00% 4 Missing ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5568      +/-   ##
==========================================
+ Coverage   15.32%   15.39%   +0.06%     
==========================================
  Files        1721     1702      -19     
  Lines      118559   116117    -2442     
  Branches    37995    36825    -1170     
==========================================
- Hits        18169    17872     -297     
+ Misses      79657    77870    -1787     
+ Partials    20733    20375     -358     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.43% <0.00%> (+0.10%) ⬆️ Carriedforward from 7320d20

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi enabled auto-merge (squash) November 21, 2023 02:51
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit a7e5774 into autowarefoundation:main Nov 24, 2023
18 of 23 checks passed
@YoshiRi YoshiRi deleted the feat/fix_iou_functions_roi_cluster_fusion branch November 24, 2023 06:28
YoshiRi added a commit to YoshiRi/autoware.universe that referenced this pull request Nov 29, 2023
…arefoundation#5568)

* enable to show debug iou value in roi_cluster_fusion

Signed-off-by: yoshiri <[email protected]>

* refactor iou draw settings

Signed-off-by: yoshiri <[email protected]>

* add backgroud color to iou

Signed-off-by: yoshiri <[email protected]>

* prevent object copying when debugger is not enabled

Signed-off-by: yoshiri <[email protected]>

* fix roi geometry functions

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…arefoundation#5568)

* enable to show debug iou value in roi_cluster_fusion

Signed-off-by: yoshiri <[email protected]>

* refactor iou draw settings

Signed-off-by: yoshiri <[email protected]>

* add backgroud color to iou

Signed-off-by: yoshiri <[email protected]>

* prevent object copying when debugger is not enabled

Signed-off-by: yoshiri <[email protected]>

* fix roi geometry functions

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 14, 2024
…arefoundation#5568)

* enable to show debug iou value in roi_cluster_fusion

Signed-off-by: yoshiri <[email protected]>

* refactor iou draw settings

Signed-off-by: yoshiri <[email protected]>

* add backgroud color to iou

Signed-off-by: yoshiri <[email protected]>

* prevent object copying when debugger is not enabled

Signed-off-by: yoshiri <[email protected]>

* fix roi geometry functions

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants