-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): remove debug message #5638
Merged
zulfaqar-azmi-t4
merged 1 commit into
autowarefoundation:main
from
zulfaqar-azmi-t4:feat-planning-msgs-safety-check-debug-msgs
Nov 30, 2023
Merged
feat(lane_change): remove debug message #5638
zulfaqar-azmi-t4
merged 1 commit into
autowarefoundation:main
from
zulfaqar-azmi-t4:feat-planning-msgs-safety-check-debug-msgs
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
Nov 21, 2023
7 tasks
zulfaqar-azmi-t4
force-pushed
the
feat-planning-msgs-safety-check-debug-msgs
branch
from
November 27, 2023 03:51
590b33f
to
8ec4919
Compare
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
November 27, 2023 03:54
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 27, 2023
zulfaqar-azmi-t4
force-pushed
the
feat-planning-msgs-safety-check-debug-msgs
branch
from
November 30, 2023 02:59
5d2abeb
to
02300fe
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
feat-planning-msgs-safety-check-debug-msgs
branch
from
November 30, 2023 03:22
02300fe
to
0a86b3e
Compare
github-actions
bot
removed
the
component:common
Common packages from the autoware-common repository. (auto-assigned)
label
Nov 30, 2023
zulfaqar-azmi-t4
changed the title
feat(behavior_path_planner): safety check msgs for debug
feat(lane_change): remove debug message
Nov 30, 2023
rej55
approved these changes
Nov 30, 2023
zulfaqar-azmi-t4
merged commit Nov 30, 2023
3ca00b2
into
autowarefoundation:main
27 of 30 checks passed
zulfaqar-azmi-t4
deleted the
feat-planning-msgs-safety-check-debug-msgs
branch
December 4, 2023 09:45
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lane change debug message is rarely used. This impacts the maintenance cost of the module. This PR aims to remove the debug message implementation.
Related links
None
Tests performed
None
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.