Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): remove debug message #5638

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Nov 21, 2023

Description

Lane change debug message is rarely used. This impacts the maintenance cost of the module. This PR aims to remove the debug message implementation.

Related links

None

Tests performed

None

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 21, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat-planning-msgs-safety-check-debug-msgs branch from 590b33f to 8ec4919 Compare November 27, 2023 03:51
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review November 27, 2023 03:54
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 27, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat-planning-msgs-safety-check-debug-msgs branch from 5d2abeb to 02300fe Compare November 30, 2023 02:59
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat-planning-msgs-safety-check-debug-msgs branch from 02300fe to 0a86b3e Compare November 30, 2023 03:22
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 30, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title feat(behavior_path_planner): safety check msgs for debug feat(lane_change): remove debug message Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 2201 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (0a86b3e) 12.73%.
Report is 107 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 13.19% 597 Missing and 87 partials ⚠️
...anner/src/utils/avoidance/shift_line_generator.cpp 13.28% 431 Missing and 65 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.90% 187 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.56% 175 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.56% 110 Missing and 17 partials ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 0.00% 84 Missing ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.75% 56 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 8.62% 53 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
... and 23 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5638       +/-   ##
===========================================
- Coverage   15.32%   12.73%    -2.59%     
===========================================
  Files        1721      111     -1610     
  Lines      118559    15220   -103339     
  Branches    37995     8507    -29488     
===========================================
- Hits        18169     1939    -16230     
+ Misses      79657    10264    -69393     
+ Partials    20733     3017    -17716     
Flag Coverage Δ
differential 12.73% <12.10%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 3ca00b2 into autowarefoundation:main Nov 30, 2023
27 of 30 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-planning-msgs-safety-check-debug-msgs branch December 4, 2023 09:45
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants