feat!: remove planning factor type #5793
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 4 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Complex Method velocity_steering_factors_panel.cpp: VelocitySteeringFactorsPanel::onSteeringFactors
- Complex Method planning.cpp: PlanningNode::on_timer
- Complex Method planning.cpp: convert_velocity_behavior
- Overall Code Complexity planning.cpp
Annotations
Check notice on line 176 in common/tier4_state_rviz_plugin/src/velocity_steering_factors_panel.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
VelocitySteeringFactorsPanel::onSteeringFactors decreases in cyclomatic complexity from 11 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 129 in system/default_ad_api/src/planning.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
PlanningNode::on_timer decreases in cyclomatic complexity from 12 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 65 in system/default_ad_api/src/planning.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
convert_velocity_behavior is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in system/default_ad_api/src/planning.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Overall Code Complexity
The mean cyclomatic complexity in this module is no longer above the threshold