fix(start_planner): refine shift pull out path to start pose #5874
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Dec 14, 2023 in 43s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method shift_pull_out.cpp: ShiftPullOut::calcPullOutPaths
- Excess Number of Function Arguments shift_pull_out.cpp: ShiftPullOut::refineShiftedPathToStartPose
Annotations
Check warning on line 359 in planning/behavior_path_start_planner_module/src/shift_pull_out.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
ShiftPullOut::calcPullOutPaths already has high cyclomatic complexity, and now it increases in Lines of Code from 129 to 131. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 211 in planning/behavior_path_start_planner_module/src/shift_pull_out.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
ShiftPullOut::refineShiftedPathToStartPose has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Loading